From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NiFd0-0002Kq-Qd for garchives@archives.gentoo.org; Thu, 18 Feb 2010 23:17:50 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 783F2E0A4A; Thu, 18 Feb 2010 23:17:48 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 87F5AE09C0 for ; Thu, 18 Feb 2010 23:17:35 +0000 (UTC) Received: from [192.168.1.4] (smer.tone.cz [89.250.247.23]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id CD9621B4076 for ; Thu, 18 Feb 2010 23:17:34 +0000 (UTC) Message-ID: <4B7DCA66.3040507@gentoo.org> Date: Fri, 19 Feb 2010 00:16:54 +0100 From: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100216 Thunderbird/3.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] New eclass for x11 packages References: <4B7DC046.7010001@gentoo.org> <201002182311.38065.levertond@googlemail.com> In-Reply-To: <201002182311.38065.levertond@googlemail.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: e32c1d14-8ea0-4c53-8afe-4f1a1fde1ff9 X-Archives-Hash: 291228fba22eb3505c9defb4b9d9b02c -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 19.2.2010 00:11, David Leverton napsal(a): > On Thursday 18 February 2010 22:33:42 Tom=C3=A1=C5=A1 Chv=C3=A1tal wrot= e: >> [[ ${PN} =3D=3D util-macros ]] || DEPEND+=3D" >=3Dx11-misc/util-macro= s-1.3.0" >> [[ ${PN} =3D=3D font-util ]] || DEPEND+=3D" >=3Dmedia-fonts/font-util= -1.1.1-r1" >=20 > Do non-fonts really need font-util there? Looks like that sets up a ni= ce=20 > circular dependency. The same dep is in x-modular eclass. I spoted it in some fonts packages as required so i left it there. Good work/idea would be if someone doublecheck that one :] >=20 >> [[ -e "./configure.ac" ]] && eautoreconf || ewarn "Unable to autore= conf=20 > the configure script. Things may fail." >=20 > That'll ewarn if configure.ac doesn't exist at all. Doesn't eautorecon= f die=20 > anyway if it fails, and if not, is it a good idea for failures to only = give a=20 > warning? >=20 That || die is not for eautoreconf [[ -e "something" ]] && somethingexists || somethingisnotexisting For your behaviour it would have to look like this [[ -e "something" ]] && { somethingexists || die if the commands failed ;= } Tomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkt9ymYACgkQHB6c3gNBRYe5kQCgjpAgHUl7icElBtdAUHTcfPOI wjkAn1CFH/9VxaO9IBnNMlVpLQT60JX+ =3D+A3h -----END PGP SIGNATURE-----