From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NeFTL-0003Tz-FS for garchives@archives.gentoo.org; Sun, 07 Feb 2010 22:19:20 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7F062E0F3F; Sun, 7 Feb 2010 22:19:15 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 4F693E0DFE for ; Sun, 7 Feb 2010 22:18:56 +0000 (UTC) Received: from [192.168.22.10] (ip68-4-152-120.oc.oc.cox.net [68.4.152.120]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id D00761B422C for ; Sun, 7 Feb 2010 22:18:55 +0000 (UTC) Message-ID: <4B6F3C7F.700@gentoo.org> Date: Sun, 07 Feb 2010 14:19:43 -0800 From: Zac Medico User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.7) Gecko/20100201 Thunderbird/3.0.1 ThunderBrowse/3.2.6.8 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Calling unknown commands in an ebuild References: <1265577010.28554.15.camel@blackhole.cddr.org> In-Reply-To: <1265577010.28554.15.camel@blackhole.cddr.org> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: c5a197ee-05ca-435d-b4c4-69b984ea114b X-Archives-Hash: d9d4f6226ccd31cdd79ea92f4a010f7f On 02/07/2010 01:10 PM, Stelian Ionescu wrote: > Wouldn't it be a good idea to use "set -e" in the ebuild environment ? > I've seen cases of ebuilds calling epatch without inheriting from eutils > which compiled and installed (apparently) fine but possibly broken > binaries. Examples of cases where "set -e" would have helped: 303849, > 297063, 260279, 221257, > https://bugs.gentoo.org/buglist.cgi?quicksearch=command+not+found > and perhaps others I haven't managed to find in bugzilla I don't know what kind of side-effects set -e would introduce, but we can easily add a repoman check for epatch calls without eutils inherit. Portage already does a search of the build log for 'command not found' messages and generates a QA warnings. Set PORTAGE_ELOG_CLASSES="${PORTAGE_ELOG_CLASSES} qa" in /etc/make.conf if you want to have those warnings logged. -- Thanks, Zac