From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NRYXD-0002pf-Lp for garchives@archives.gentoo.org; Sun, 03 Jan 2010 22:02:53 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 50B26E0616 for ; Sun, 3 Jan 2010 22:02:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 88DFFE085A for ; Sun, 3 Jan 2010 20:55:25 +0000 (UTC) Received: from [192.168.11.186] (68-118-248-58.dhcp.oxfr.ma.charter.com [68.118.248.58]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id B94CC67E83; Sun, 3 Jan 2010 20:55:24 +0000 (UTC) Message-ID: <4B41042F.5030406@gentoo.org> Date: Sun, 03 Jan 2010 15:55:11 -0500 From: Joe Sapp Organization: Gentoo Linux User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091210 Lightning/1.0pre Thunderbird/3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org CC: Christian Faulhammer Subject: Re: [gentoo-dev] Re: Major changes to gdesklets.eclass References: <4B29A0E4.4040608@gentoo.org> <20091229095458.456afc15@gentoo.org> In-Reply-To: <20091229095458.456afc15@gentoo.org> X-Enigmail-Version: 1.0 OpenPGP: id=721E3B48 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE605300BF9E7D0735A348C67" X-Archives-Salt: da18d2c7-3bc6-4cba-9e60-d9af8ce48d39 X-Archives-Hash: e1c5a324978bf42ae5945b54bae692d3 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE605300BF9E7D0735A348C67 Content-Type: multipart/mixed; boundary="------------010707010101080404050109" This is a multi-part message in MIME format. --------------010707010101080404050109 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for looking at this Christian. On 12/29/2009 03:54 AM, Christian Faulhammer wrote: > Looks fine so far. What puzzled me is the documentation of the SLOT > variable. What is the motivation to do so? It would be possible for two different versions of a Control to be instal= led and work with gdesklets-core. An id string is calculated based on the interface to the Control, and this string is used by the Desklet to refer= ence the Control. So if two versions of a Control have different interfaces, Desklet "A" could use the older version and Desklet "B" could use the new= er version. The core program would allow it and I'd like to provide the sup= port for doing this in portage. This is why obz and I originally chose to ins= tall to a directory identified by the Control name and its id string (i.e. "/usr/lib/gdesklets/Controls/ImageSlideShow_cdu4rwmfeuauyw2wwuaczc3lr-2")= =2E > * Sometimes you give a default on undefined ROOT variable, sometimes > not. Please make it consistent for cosmetic reasons. Okay. I guess since the PMS specifies that it "must be non-empty and end= in a trailing slash", I will remove the default on undefined. > * addwrite "${ROOT}/root/.gnome2": Is this unconditionally necessary? > Or could a "boolean" in the ebuild be set to activate it? Unfortunately, it seems to be unconditionally necessary. Bug #128289 [1]= still seems to apply upstream (see comment #18). I have not looked into = glib source code since this issue was originally "fixed" [2]. > * DISPLAY variable export could be done with the assignment. Or is the= > export always needed? Done. I would like this to go away, but haven't touched the gdesklets-control-getid script in a long time. The easy way was to expor= t DISPLAY. > * Is the file name LICENSE always used for the license or is COPYING > for example also possible? I believe it will always be LICENSE if packaged according to upstream [3]= =2E I believe it is not allowed to be something else in order to be uploaded to= the main site, but as the link is down atm I can't check it. > * einfo "Installing Control ${CTRL_DIRNAME}": Is not mirrored in the > desklet branch of the if clause. True. Originally it was mirrored, but some Desklets in the tree (I'm thi= nking of x11-plugins/desklet-ftb right now) contain multiple Desklets (I can't remember if this is allowed any more with the requirements specified in [= 3], but I'm open to suggestions). I thought it was a good compromise to have= the einfo lines in pkg_postinst. The difference between the two is that mult= iple Controls cannot be packaged together (both under the new upstream packagi= ng requirements and for this eclass to work). Patch to the original revision is attached. -- Joe [1] http://bugs.gentoo.org/show_bug.cgi?id=3D128289#c18 [2] http://bugs.gentoo.org/show_bug.cgi?id=3D126890 [3] http://gdesklets.de/index.php?q=3Dnode/2 --------------010707010101080404050109 Content-Type: text/plain; name="gdesklets-20091101-20090103.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="gdesklets-20091101-20090103.patch" LS0tIGdkZXNrbGV0cy0yMDA5MTEwMS5lY2xhc3MJMjAwOS0xMi0xNiAyMjowNjowNS4wMDAw MDAwMDAgLTA1MDAKKysrIGdkZXNrbGV0cy0yMDA5MDEwMy5lY2xhc3MJMjAxMC0wMS0wMyAx NTo1Mjo1My4wMDAwMDAwMDAgLTA1MDAKQEAgLTY3LDcgKzY3LDcgQEAKIElVU0U9IiIKIFJE RVBFTkQ9Ij49Z25vbWUtZXh0cmEvZ2Rlc2tsZXRzLWNvcmUtMC4zNi4xLXIzIgogCi1HREVT S0xFVFNfSU5TVF9ESVI9IiR7Uk9PVDotL311c3IvJChnZXRfbGliZGlyKS9nZGVza2xldHMi CitHREVTS0xFVFNfSU5TVF9ESVI9IiR7Uk9PVH11c3IvJChnZXRfbGliZGlyKS9nZGVza2xl dHMiCiAKICMgQEZVTkNUSU9OOiBnZGVza2xldHNfc3JjX2luc3RhbGwKICMgQERFU0NSSVBU SU9OOgpAQCAtODgsOCArODgsNyBAQAogCiAJIyBDaGVjayB0byBzZWUgaWYgRElTUExBWSBp cyBzZXQgZm9yIHRoZQogCSMgZ2Rlc2tsZXRzLWNvbnRyb2wtZ2V0aWQgc2NyaXB0IHRvIHJ1 biB3aXRob3V0IGVycm9yCi0JWyAteiAiJHtESVNQTEFZfSIgXSAmJiBESVNQTEFZPSIiCi0J ZXhwb3J0IERJU1BMQVkKKwlbIC16ICIke0RJU1BMQVl9IiBdICYmIGV4cG9ydCBESVNQTEFZ PSIiCiAKIAlkZWJ1Zy1wcmludC1zZWN0aW9uIGRvY3NfaW5zdGFsbAogCg== --------------010707010101080404050109-- --------------enigE605300BF9E7D0735A348C67 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAktBBDoACgkQ7TKxt3IeO0g82ACgm6ZrSzrvy/+WPAnVrOsnshxs WWoAoIjOkcWDBuUqTY8V15DSBlXB/XPy =IB7v -----END PGP SIGNATURE----- --------------enigE605300BF9E7D0735A348C67--