Re: [gentoo-dev] Re: [RFC] base.eclass

["Tomáš Chvátal" <scarabeus@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 3.1.2010 01:56, Mark Bateman napsal(a):
> There seems to be alot of unquoted variables
> 
> 65                 base_src_util $@
This is not problem
> 
> 90                 case $1 in
Yarp this is problem and fixed
> 
> 95                                 [[ ! -z "${A}" ]] && unpack ${A}
${A} is not used quoted :]
> 
>  117   oldval=${EPATCH_SOURCE}
>  118   EPATCH_SOURCE=${x}
>  120   EPATCH_SOURCE=${oldval}
Variables assignment is not requiring quoting.
> 
> Also a typo: an "n" slipped in
> 130                                 popd > n/dev/null
Great spot, fixed

Thanks for your help with review :]

Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAks/+UkACgkQHB6c3gNBRYfBqQCcC3iJXXHsGWLyQg2Ab8+/wH0h
/BgAoKxzfgbhl0MbKh8UUn1hTJyTzo1z
=Fv6C
-----END PGP SIGNATURE-----