From: "Petteri Räty" <betelgeuse@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Heads up: cmake-utils.eclass changes
Date: Mon, 14 Dec 2009 14:43:18 +0200 [thread overview]
Message-ID: <4B2632E6.5000300@gentoo.org> (raw)
In-Reply-To: <4B24FA22.2020802@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On 12/13/2009 04:28 PM, Jonathan Callen wrote:
> Recently a change was made to cmake-utils.eclass, changing the
> mycmakeargs parameter from a flat string to an array. This change was
> also made to kde4-{base,meta}.eclass. The primary reason for this
> change was to allow parameters passed to cmake to contain spaces (such
> as "${S}" or "${EPREFIX}"). Currently, there is code in these eclasses
> to properly convert a string to an array, keeping the previous behavior.
> This code works in almost every case *except* if you want to change
> mycmakeargs in src_test and call cmake-utils_src_configure again. The
> few instances of this in the tree have been fixed to use arrays, as
> should all new ebuilds.
>
> The plan is to eventually remove this backwards-compatibility code, once
> all usages in the tree have been converted.
>
The policy has been to not change the API of eclasses because you can
have user written ebuilds in overlays expecting certain behavior.
Regards,
Petteri
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2009-12-14 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 14:28 [gentoo-dev] Heads up: cmake-utils.eclass changes Jonathan Callen
2009-12-14 12:43 ` Petteri Räty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2632E6.5000300@gentoo.org \
--to=betelgeuse@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox