[gentoo-dev] Re: gentoo-x86 commit in net-mail/getmail: ChangeLog getmail-4.9.2.ebuild

[gentoo-dev] Re: gentoo-x86 commit in net-mail/getmail: ChangeLog getmail-4.9.2.ebuild

[Torsten Veller]

* "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> grobian     09/10/11 15:04:33
> 
>   Modified:             ChangeLog getmail-4.9.2.ebuild
>   Log:
>   Use ED for Prefix compatability, marked ~ppc-macos and ~x64-solaris
>   (Portage version: 2.2.00.14552-prefix/cvs/Darwin powerpc, RepoMan options: --force)
> 
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-mail/getmail/getmail-4.9.2.ebuild?rev=1.2&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-mail/getmail/getmail-4.9.2.ebuild?rev=1.2&content-type=text/plain
> diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-mail/getmail/getmail-4.9.2.ebuild?r1=1.1&r2=1.2
> 
> Index: getmail-4.9.2.ebuild
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/net-mail/getmail/getmail-4.9.2.ebuild,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- getmail-4.9.2.ebuild	23 Jul 2009 19:27:29 -0000	1.1
> +++ getmail-4.9.2.ebuild	11 Oct 2009 15:04:33 -0000	1.2
> @@ -1,6 +1,6 @@
>  # Copyright 1999-2009 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/net-mail/getmail/getmail-4.9.2.ebuild,v 1.1 2009/07/23 19:27:29 tove Exp $
> +# $Header: /var/cvsroot/gentoo-x86/net-mail/getmail/getmail-4.9.2.ebuild,v 1.2 2009/10/11 15:04:33 grobian Exp $
>  
>  inherit distutils
>  
> @@ -10,7 +10,7 @@
>  
>  LICENSE="GPL-2"
>  SLOT="4"
> -KEYWORDS="~alpha ~amd64 ~ppc ~sparc ~x86"
> +KEYWORDS="~alpha ~amd64 ~ppc ~sparc ~x86 ~ppc-macos ~x64-solaris"
>  IUSE=""
>  
>  DEPEND=">=dev-lang/python-2.3.3"
> @@ -19,14 +19,15 @@
>  PYTHON_MODNAME=getmailcore
>  
>  src_install() {
> +	[[ -z ${ED} ]] && local ED=${D}
>  	distutils_src_install
>  
>  	# handle docs the gentoo way
> -	rm "${D}"/usr/share/doc/${P}/COPYING || die
> +	rm "${ED}"/usr/share/doc/${P}/COPYING || die
>  	if [[ ${P} != ${PF} ]] ; then
> -		mv "${D}"/usr/share/doc/${P} "${D}"/usr/share/doc/${PF} || die
> +		mv "${ED}"/usr/share/doc/${P} "${ED}"/usr/share/doc/${PF} || die
>  	fi
>  
>  	dodir /usr/share/doc/${PF}/html
> -	mv "${D}"/usr/share/doc/${PF}/*.{html,css} "${D}"/usr/share/doc/${PF}/html || die
> +	mv "${ED}"/usr/share/doc/${PF}/*.{html,css} "${ED}"/usr/share/doc/${PF}/html || die
>  }

Can you please explain these changes? What is ED? Why does it need
changes in the ebuild at all?
Where is the documentation?

Re: [gentoo-dev] Re: gentoo-x86 commit in net-mail/getmail: ChangeLog getmail-4.9.2.ebuild

[Fabian Groffen]

On 11-10-2009 17:14:29 +0200, Torsten Veller wrote:
> * "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> > grobian     09/10/11 15:04:33
> > 
> >   Modified:             ChangeLog getmail-4.9.2.ebuild
> >   Log:
> >   Use ED for Prefix compatability, marked ~ppc-macos and ~x64-solaris
[snip]
> Can you please explain these changes? What is ED? Why does it need
> changes in the ebuild at all?

We are working on a proper explanation targetted to devs of this.  I'm
sorry for the inconvenience caused.

> Where is the documentation?

For the moment you can find our own documentation here:
http://www.gentoo.org/proj/en/gentoo-alt/prefix/techdocs.xml


-- 
Fabian Groffen
Gentoo on a different level

Re: [gentoo-dev] Re: gentoo-x86 commit in net-mail/getmail: ChangeLog getmail-4.9.2.ebuild

[Jeroen Roovers]

On Tue, 13 Oct 2009 21:22:13 +0200
Fabian Groffen <grobian@gentoo.org> wrote:

> We are working on a proper explanation targetted to devs of this.  I'm
> sorry for the inconvenience caused.

How large of a change to the tree will this involve? Is it a small
number of packages that need to be fixed through the ebuilds right now?
will that number grow? Will you notify package maintainers of these
changes?

> For the moment you can find our own documentation here:
> http://www.gentoo.org/proj/en/gentoo-alt/prefix/techdocs.xml

Where did you document D -> ED? Can you briefly describe what it does?


Regards,
     jer

Re: [gentoo-dev] Re: gentoo-x86 commit in net-mail/getmail: ChangeLog getmail-4.9.2.ebuild

[Gilles Dartiguelongue]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Le mardi 13 octobre 2009 à 23:48 +0200, Jeroen Roovers a écrit :
> On Tue, 13 Oct 2009 21:22:13 +0200
> Fabian Groffen <grobian@gentoo.org> wrote:
> 
> > We are working on a proper explanation targetted to devs of this.  I'm
> > sorry for the inconvenience caused.
> 
> How large of a change to the tree will this involve? Is it a small
> number of packages that need to be fixed through the ebuilds right now?
> will that number grow? Will you notify package maintainers of these
> changes?

Apparently not, it's not that the change is complicated but I (and the
rest of the gnome herd) would rather have an upfront information about
any kind of changes to our ebuilds than discovering these through
gentoo-commits...

> 
> > For the moment you can find our own documentation here:
> > http://www.gentoo.org/proj/en/gentoo-alt/prefix/techdocs.xml
> 
> Where did you document D -> ED? Can you briefly describe what it does?

I'd also like to know why this cannot be handled by the usual D with
package manager support, this would save a lot of changes to ebuilds
(like the python abi stuff that still has no documentation afaik).

I sincerely want to see progress in the way we handle prefix, python
abis and all the cool stuff that is still in preparation, but let's do
it in a way to makes every dev aware of it (sending a mail to
gentoo-dev-announce for example), thanks.

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] Re: gentoo-x86 commit in net-mail/getmail: ChangeLog getmail-4.9.2.ebuild

[Jeremy Olexa]

Gilles Dartiguelongue wrote:
> Le mardi 13 octobre 2009 à 23:48 +0200, Jeroen Roovers a écrit :
>> On Tue, 13 Oct 2009 21:22:13 +0200
>> Fabian Groffen <grobian@gentoo.org> wrote:
>>
>>> We are working on a proper explanation targetted to devs of this.  I'm
>>> sorry for the inconvenience caused.
>> How large of a change to the tree will this involve? Is it a small
>> number of packages that need to be fixed through the ebuilds right now?
>> will that number grow? Will you notify package maintainers of these
>> changes?
> 
> Apparently not, it's not that the change is complicated but I (and the
> rest of the gnome herd) would rather have an upfront information about
> any kind of changes to our ebuilds than discovering these through
> gentoo-commits...

Jeroen / Gilles : Coming soon. The internal draft was just prepared but 
Fabian will be sending it.

> 
>>> For the moment you can find our own documentation here:
>>> http://www.gentoo.org/proj/en/gentoo-alt/prefix/techdocs.xml
>> Where did you document D -> ED? Can you briefly describe what it does?

See the section "The variables ED and EROOT" on that link. I don't want 
to open it up for discussion on this thread though.

> 
> I'd also like to know why this cannot be handled by the usual D with
> package manager support, this would save a lot of changes to ebuilds
> (like the python abi stuff that still has no documentation afaik).
> 
> I sincerely want to see progress in the way we handle prefix, python
> abis and all the cool stuff that is still in preparation, but let's do
> it in a way to makes every dev aware of it (sending a mail to
> gentoo-dev-announce for example), thanks.

Thanks for your support on behalf of the Prefix team,
-Jeremy