From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1MkaXv-00054a-Ok for garchives@archives.gentoo.org; Mon, 07 Sep 2009 09:29:59 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B8E5CE0942; Mon, 7 Sep 2009 09:29:58 +0000 (UTC) Received: from mtaout01-winn.ispmail.ntl.com (mtaout01-winn.ispmail.ntl.com [81.103.221.47]) by pigeon.gentoo.org (Postfix) with ESMTP id 56A13E0942 for ; Mon, 7 Sep 2009 09:29:58 +0000 (UTC) Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090907092953.ONLC6742.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Mon, 7 Sep 2009 10:29:53 +0100 Received: from zog.reactivated.net ([86.14.215.141]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090907092953.PIFI13254.aamtaout01-winn.ispmail.ntl.com@zog.reactivated.net> for ; Mon, 7 Sep 2009 10:29:53 +0100 Received: from [127.0.0.1] (localhost [127.0.0.1]) by zog.reactivated.net (Postfix) with ESMTP id 106B39D4055 for ; Mon, 7 Sep 2009 10:29:51 +0100 (BST) Message-ID: <4AA4D22B.7000805@gentoo.org> Date: Mon, 07 Sep 2009 10:28:11 +0100 From: Daniel Drake User-Agent: Thunderbird 2.0.0.23 (X11/20090904) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.0 c=1 a=AqcRlQNhA_4A:10 a=nW2MUq8jkItf9d3yilgA:9 a=1LGTrWM6gBIXHZhJ80b0x6S7ZSMA:4 X-Archives-Salt: b63527e1-f488-4054-a6c9-6cfec8f33d26 X-Archives-Hash: c9886143c19148be1196ae18c39bce01 Robin H. Johnson wrote: > It does NOT check /proc/config.gz presently. The original logic against > not checking /proc was that we were targeting the kernel being built, > but that's moot given the use of `uname -r` in OUTPUT_DIR. That seems like a bug. OUTPUT_DIR should default to unset which would cause the internal KV_OUT_DIR to be set to KV_DIR. However I can see from the code that's not the case, and it's not clear why. Relying on "uname -r" or /proc/config.gz is still something we should avoid (unless user configured, perhaps, or in very exceptional circumstances) however it looks like this isn't a change that you are proposing. Thanks for working on this. It's a sensitive area so please take care and help people pick up the pieces. If you are really motivated, it might be worth rethinking the whole separate output directory implementation. Daniel