From: Daniel Drake <dsd@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building
Date: Mon, 07 Sep 2009 10:28:11 +0100 [thread overview]
Message-ID: <4AA4D22B.7000805@gentoo.org> (raw)
In-Reply-To: <robbat2-20090830T192224-029701861Z@orbis-terrarum.net>
Robin H. Johnson wrote:
> It does NOT check /proc/config.gz presently. The original logic against
> not checking /proc was that we were targeting the kernel being built,
> but that's moot given the use of `uname -r` in OUTPUT_DIR.
That seems like a bug. OUTPUT_DIR should default to unset which would
cause the internal KV_OUT_DIR to be set to KV_DIR. However I can see
from the code that's not the case, and it's not clear why.
Relying on "uname -r" or /proc/config.gz is still something we should
avoid (unless user configured, perhaps, or in very exceptional
circumstances) however it looks like this isn't a change that you are
proposing.
Thanks for working on this. It's a sensitive area so please take care
and help people pick up the pieces. If you are really motivated, it
might be worth rethinking the whole separate output directory
implementation.
Daniel
next prev parent reply other threads:[~2009-09-07 9:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 19:58 [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building Robin H. Johnson
2009-08-30 20:21 ` Mike Auty
2009-08-30 21:29 ` Robin H. Johnson
2009-08-30 21:58 ` Mike Auty
2009-08-30 23:02 ` Robin H. Johnson
2009-08-30 23:30 ` Mike Auty
2009-08-30 23:46 ` Robin H. Johnson
2009-08-31 0:00 ` Mike Auty
2009-08-31 0:27 ` Robin H. Johnson
2009-08-31 0:41 ` Mike Auty
2009-08-31 22:43 ` Mike Auty
2009-09-07 9:28 ` Daniel Drake [this message]
2009-09-07 10:42 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA4D22B.7000805@gentoo.org \
--to=dsd@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox