From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4866315800A for ; Fri, 21 Jul 2023 18:23:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9D36BE0957; Fri, 21 Jul 2023 18:23:00 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 55E8AE0943 for ; Fri, 21 Jul 2023 18:23:00 +0000 (UTC) Message-ID: <49ec2455-9055-c9f7-9619-723f0d2a7ebf@gentoo.org> Date: Fri, 21 Jul 2023 21:22:51 +0300 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: [gentoo-dev] Re: [RFC PATCH] metadata: Add gnome package stabilization groups Content-Language: en-US To: Matt Turner , gentoo-dev@lists.gentoo.org References: <20230719161117.2561126-1-mattst88@gentoo.org> From: Arthur Zamarin In-Reply-To: <20230719161117.2561126-1-mattst88@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------cHwmbMRlj8afAutOeuW9fX1U" X-Archives-Salt: f42ca9fd-68ab-4cdf-a4eb-be82c8910772 X-Archives-Hash: 0fedf47cbff76d12a20b95e9aa420111 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------cHwmbMRlj8afAutOeuW9fX1U Content-Type: multipart/mixed; boundary="------------ERRZ4D0fQgqQXFlLwgsz6yTb"; protected-headers="v1" From: Arthur Zamarin To: Matt Turner , gentoo-dev@lists.gentoo.org Message-ID: <49ec2455-9055-c9f7-9619-723f0d2a7ebf@gentoo.org> Subject: Re: [RFC PATCH] metadata: Add gnome package stabilization groups References: <20230719161117.2561126-1-mattst88@gentoo.org> In-Reply-To: <20230719161117.2561126-1-mattst88@gentoo.org> --------------ERRZ4D0fQgqQXFlLwgsz6yTb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 19/07/2023 19.10, Matt Turner wrote: > Signed-off-by: Matt Turner > --- > Feel free to bikeshed the location, structure, file-format, etc. >=20 > metadata/stabilization-groups/gnome/evolution | 3 +++ > metadata/stabilization-groups/gnome/glib | 3 +++ > metadata/stabilization-groups/gnome/gnome-shell | 4 ++++ > metadata/stabilization-groups/gnome/gobject-introspection | 2 ++ > metadata/stabilization-groups/gnome/sysprof | 3 +++ > metadata/stabilization-groups/gnome/vala | 2 ++ > metadata/stabilization-groups/gnome/vte | 3 +++ > 7 files changed, 20 insertions(+) > create mode 100644 metadata/stabilization-groups/gnome/evolution > create mode 100644 metadata/stabilization-groups/gnome/glib > create mode 100644 metadata/stabilization-groups/gnome/gnome-shell > create mode 100644 metadata/stabilization-groups/gnome/gobject-introsp= ection > create mode 100644 metadata/stabilization-groups/gnome/sysprof > create mode 100644 metadata/stabilization-groups/gnome/vala > create mode 100644 metadata/stabilization-groups/gnome/vte >=20 So semi-formalizing it before I implement parsing it in pkgcore: 1. everything is located under "metadata/stabilization-groups/" 2. We search recursively as much as needed, so all files are included in any depth. 3. Group name plays similarly to path, so here the group name would be "@gnome/vte" (at least for `pkgdev bugs` invocations). By using full path, we are safe from name collisions. 4. The file itself uses similar format to our various profiles files. Ignore white-spaces before and after, "#" as a comment. Only one "cat/pkg" per line. 5. I think for now we can go without mandatory copyright header... How it will affect `pkgdev bugs` invocations? I'll use your sets as example. Let's say our invocation is `pkgdev bugs dev-libs/glib @gnome/vala`. - if a set is passed (anything starting with @), replace it with all the contents of that set (so "@gnome/vala" equals to "dev-libs/vala-common dev-lang/vala"). - Drop every package from the pkglist whose latest matching package to the restricts expression is already latest (so nothing better to do). - pkgdev bugs builds the full graph as it does today. Let's say it decided it needs to also add "dev-util/glib-utils". - For every defined set, all the packages included in graph and in the set are merged into one bug. This means we would get one bug for "@gnome/vala" ("dev-libs/vala-common dev-lang/vala") and one bug for "@gnome/glib" ("dev-libs/glib dev-util/glib-utils"). Notice that it didn't add the other package in that set ("dev-util/gdbus-codegen") since it wasn't requested or required. Does this flow seems logical and flexible enough? I don't think auto adding whole set if any one of it's package is required is a good idea since it might explode? If folks want to stable the whole set, explicit pass it as arg in the invocation. Do note that I'm open to other flows and usages, everything is open for me (I didn't start to implement it, just scratches in my notebook). --=20 Arthur Zamarin arthurzam@gentoo.org Gentoo Linux developer (Python, pkgcore stack, Arch Teams, GURU) --------------ERRZ4D0fQgqQXFlLwgsz6yTb-- --------------cHwmbMRlj8afAutOeuW9fX1U Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE/axFlFuH2ptjtO5EAqCvUD0SBQQFAmS6zPsACgkQAqCvUD0S BQR6iggAp4SM0BwhuJOovN9RLnRy+CyuUIbeQVlzXJgkEP0nuJfDJuig27O5w34e 0cla4XdD+6BuF+OfpqiZg+V50Rj5FCN3km0pNv2q6lnGFqhn2oKVVTLTgweclDzb yJPlid0pG6sRglRqrUO3B+o1fo/mfQ+cMhw7rb0tdvfN535RfgkXuLcqys60FM3N p3xHuiaDyTswKclAT33CXPntC9rhq3Kj09j485CNT3CSKcDR7POq1iAtSN1GSzA5 ZeOWe3OngiUFXH+W/Ca6C1t+434fvjCOHRjRp/4/MoMQWoU0784AuGipvdgIPR+T tCPZrtxy+qnyyU2Ksr20iQm68gT96Q== =TVjS -----END PGP SIGNATURE----- --------------cHwmbMRlj8afAutOeuW9fX1U--