[gentoo-dev] Maintainence of /usr/portage/skel.* and some updates for skel.ebuild

[gentoo-dev] Maintainence of /usr/portage/skel.* and some updates for skel.ebuild

[Thomas Sachau]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

I would like to know, if there is some policy about editing skel.* files or who owns/maintains them.
Additionally, i suggest some changes to skel.ebuild:
 -fix the comment for inherit (afaik $(getlibdir) is provided by multilib eclass)
 -comment out the inherit line
 -comment out DEPEND and RDEPEND
 -remove the || die from econf
 -comment out the complete src_compile

Since it seems like people change it at will and those are minor changes, i will do them in a few
days, if noone has a good reason against them.

-- 
Thomas Sachau

Gentoo Linux Developer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 315 bytes --]

Re: [gentoo-dev] Maintainence of /usr/portage/skel.* and some updates for skel.ebuild

[Olivier Crête]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

On Tue, 2009-03-10 at 20:42 +0100, Thomas Sachau wrote:
> I would like to know, if there is some policy about editing skel.* files or who owns/maintains them.
> Additionally, i suggest some changes to skel.ebuild:
>  -fix the comment for inherit (afaik $(getlibdir) is provided by multilib eclass)
>  -comment out the inherit line
>  -comment out DEPEND and RDEPEND
>  -remove the || die from econf
>  -comment out the complete src_compile

It may also be a good time to think about updating skel.eclass to use
EAPI=2

-- 
Olivier Crête
tester@gentoo.org
Gentoo Developer

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [gentoo-dev] Maintainence of /usr/portage/skel.* and some updates for skel.ebuild

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Thomas Sachau wrote:
> I would like to know, if there is some policy about editing skel.* files or who owns/maintains them.
> Additionally, i suggest some changes to skel.ebuild:
>

Posts diffs to gentoo-dev and if there are no objections --> commit.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

Re: [gentoo-dev] Maintainence of /usr/portage/skel.* and some updates for skel.ebuild

[Thomas Sachau]

[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]

Petteri Räty schrieb:
> Thomas Sachau wrote:
>> I would like to know, if there is some policy about editing skel.* files or who owns/maintains them.
>> Additionally, i suggest some changes to skel.ebuild:
>>
> 
> Posts diffs to gentoo-dev and if there are no objections --> commit.
> 
> Regards,
> Petteri
> 

ok, here my proposed diff for skel.ebuild

-- 
Thomas Sachau

Gentoo Linux Developer


[-- Attachment #1.2: skel.ebuild.diff --]
[-- Type: text/plain, Size: 2616 bytes --]

--- skel.ebuild	2009-03-16 17:50:59.000000000 +0100
+++ skel.ebuild.new	2009-03-16 18:01:36.000000000 +0100
@@ -21,14 +21,14 @@
 
 # inherit lists eclasses to inherit functions from. Almost all ebuilds should
 # inherit eutils, as a large amount of important functionality has been
-# moved there. For example, the $(get_libdir) mentioned below wont work
+# moved there. For example, the epatch call mentioned below wont work
 # without the following line:
 inherit eutils
 # A well-used example of an eclass function that needs eutils is epatch. If
 # your source needs patches applied, it's suggested to put your patch in the
 # 'files' directory and use:
 #
-#   epatch ${FILESDIR}/patch-name-here
+#   epatch "${FILESDIR}"/patch-name-here
 #
 # eclasses tend to list descriptions of how to use their functions properly.
 # take a look at /usr/portage/eclasses/ for more examples.
@@ -96,11 +96,14 @@
 # had installed on your system when you tested the package.  Then
 # other users hopefully won't be caught without the right version of
 # a dependency.
-DEPEND=""
+#DEPEND=""
 
 # Run-time dependencies. Must be defined to whatever this depends on to run.
 # The below is valid if the same run-time depends are required to compile.
-RDEPEND="${DEPEND}"
+# You only need to define this, if you have run-time dependencies or dont have
+# run-time dependencies, but compile time dependencies set in DEPEND (in this
+# case, it should be RDEPEND="").
+#RDEPEND="${DEPEND}"
 
 # Source directory; the dir where the sources can be found (automatically
 # unpacked) inside ${WORKDIR}.  The default value for S is ${WORKDIR}/${P}
@@ -108,10 +111,13 @@
 # to keep it tidy.
 #S="${WORKDIR}/${P}"
 
-src_compile() {
+
+# The following src_compile function is implemented as default by portage, so
+# you only need to call it, if you need a different behaviour.
+#src_compile() {
 	# Most open-source packages use GNU autoconf for configuration.
-	# The quickest (and preferred) way of running configure is:
-	econf || die "econf failed"
+	# The default, quickest (and preferred) way of running configure is:
+	#econf
 	#
 	# You could use something similar to the following lines to
 	# configure your package before compilation.  The "|| die" portion
@@ -135,8 +141,9 @@
 	# related to parallelism, in these cases, use emake -j1 to limit
 	# make to a single process.  The -j1 is a visual clue to others
 	# that the makefiles have bugs that have been worked around.
-	emake || die "emake failed"
-}
+
+	#emake || die "emake failed"
+#}
 
 src_install() {
 	# You must *personally verify* that this trick doesn't install

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 315 bytes --]

Re: [gentoo-dev] Maintainence of /usr/portage/skel.* and some updates for skel.ebuild

[Marijn Schouten (hkBst)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thomas Sachau wrote:
> Petteri Räty schrieb:
>> Thomas Sachau wrote:
>>> I would like to know, if there is some policy about editing skel.* files or who owns/maintains them.
>>> Additionally, i suggest some changes to skel.ebuild:
>>>
>> Posts diffs to gentoo-dev and if there are no objections --> commit.
>>
>> Regards,
>> Petteri
>>
> 
> ok, here my proposed diff for skel.ebuild
> 
> 
 # Run-time dependencies. Must be defined to whatever this depends on to run.
 # The below is valid if the same run-time depends are required to compile.
- -RDEPEND="${DEPEND}"
+# You only need to define this, if you have run-time dependencies or dont have
+# run-time dependencies, but compile time dependencies set in DEPEND (in this
+# case, it should be RDEPEND="").
+#RDEPEND="${DEPEND}"

Why not make it simple and require RDEPEND to be defined?

Marijn

- --
Gods do not want you to think, lest they lose existence.
Religions do not want you to think, lest they lose power.

Marijn Schouten (hkBst), Gentoo Lisp project, Gentoo ML
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-{lisp,ml} on FreeNode
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkm+yQkACgkQp/VmCx0OL2yXGwCgkaV9tQMuJg+A3VLjwHnCEQV2
KOcAoJ5yn+ZEEu8mZqXf5LwWWLEMb5yE
=Hpvn
-----END PGP SIGNATURE-----

Re: [gentoo-dev] Maintainence of /usr/portage/skel.* and some updates for skel.ebuild

[Jorge Manuel B. S. Vicetto]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marijn Schouten (hkBst) wrote:
> Thomas Sachau wrote:
>> Petteri Räty schrieb:
>>> Thomas Sachau wrote:
>>>> I would like to know, if there is some policy about editing skel.* files or who owns/maintains them.
>>>> Additionally, i suggest some changes to skel.ebuild:
>>>>
>>> Posts diffs to gentoo-dev and if there are no objections --> commit.
>>>
>>> Regards,
>>> Petteri
>>>
>> ok, here my proposed diff for skel.ebuild
> 
> 
>  # Run-time dependencies. Must be defined to whatever this depends on to run.
>  # The below is valid if the same run-time depends are required to compile.
> -RDEPEND="${DEPEND}"
> +# You only need to define this, if you have run-time dependencies or dont have
> +# run-time dependencies, but compile time dependencies set in DEPEND (in this
> +# case, it should be RDEPEND="").
> +#RDEPEND="${DEPEND}"
> 
> Why not make it simple and require RDEPEND to be defined?
> 
> Marijn
> 

Well, the current proposal for EAPI-3 includes killing the
RDEPEND=${DEPEND} default behaviour, so this section should be left
alone, imo.

- --
Regards,

Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org
Gentoo- forums / Userrel / Devrel / SPARC / KDE
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkm+4p0ACgkQcAWygvVEyALXcACgmsLk9yme1GI+XUoJTUGVy3H0
ssIAoJQ7Mml3VvNBSOktrU+x7XyzPDNh
=lJ9G
-----END PGP SIGNATURE-----