From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LfiaR-0005Ll-Cf for garchives@archives.gentoo.org; Fri, 06 Mar 2009 22:32:11 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C6B20E0262; Fri, 6 Mar 2009 22:32:09 +0000 (UTC) Received: from smtp03.tky.fi (smtp03.tky.fi [82.130.63.73]) by pigeon.gentoo.org (Postfix) with SMTP id 73AB9E0262 for ; Fri, 6 Mar 2009 22:32:09 +0000 (UTC) Received: from [82.130.46.209] ([82.130.46.209]) by smtp03.tky.fi (SMSSMTP 4.1.9.35) with SMTP id M2009030700320727866 for ; Sat, 07 Mar 2009 00:32:07 +0200 Message-ID: <49B1A4B4.1000804@gentoo.org> Date: Sat, 07 Mar 2009 00:33:24 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; fi; rv:1.8.1.19) Gecko/20090111 Thunderbird/2.0.0.19 Mnenhy/0.7.6.666 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] x-modular.eclass: A modified approach to EAPI support References: <20090306205729.GC22566@comet> In-Reply-To: <20090306205729.GC22566@comet> X-Enigmail-Version: 0.95.7 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF375B20C35F1DBAFB91092DD" X-Archives-Salt: 08f84127-97a3-4e0c-8623-28427cdfa202 X-Archives-Hash: c05bccbb94ddf829877a3c4a811a54bc This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF375B20C35F1DBAFB91092DD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Donnie Berkholz wrote: > I decided to try something a little different because I had some ideas = > for improving the existing EAPI patches I've seen going into other=20 > eclasses. So here is my patch for x-modular.eclass. I tested it with=20 > ebuilds using EAPIs 0, 1, and 2, and it appeared to work fine. It=20 > already happened to have a function called src_configure, so that=20 > doesn't appear in the patch. >=20 > One thing I see as an improvement is a lack of EAPI value checks=20 > throughout the ebuild to avoid repetition between the function export=20 > and the function call. Things just check whether a function was=20 > exported, which is the only place where EAPI value checks happen. >=20 > Additionally, the fallback in case statements is "I don't know what to = > do" and supported EAPIs are explicitly defined. This will make it=20 > obvious when the eclass doesn't support a new EAPI instead of it=20 > randomly failing after you try it. >=20 > Any thoughts? >=20 >=20 The other option instead of die would be DEPEND=3D"THIS-IS-NOT-VALID". Regards, Petteri --------------enigF375B20C35F1DBAFB91092DD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmxpLcACgkQcxLzpIGCsLRbeQCeJ1/2Sd30nGpW0GyS8iyChKUS s7AAn0nfuoHZpwL3no5UQze84RNC29Zs =ihly -----END PGP SIGNATURE----- --------------enigF375B20C35F1DBAFB91092DD--