From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LUkiq-0000kQ-Uy for garchives@archives.gentoo.org; Wed, 04 Feb 2009 16:35:33 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 91F1FE072A; Wed, 4 Feb 2009 16:34:50 +0000 (UTC) Received: from smtp03.tky.fi (smtp03.tky.fi [82.130.63.73]) by pigeon.gentoo.org (Postfix) with SMTP id 45101E072F for ; Wed, 4 Feb 2009 16:34:50 +0000 (UTC) Received: from [82.130.46.209] ([82.130.46.209]) by smtp03.tky.fi (SMSSMTP 4.1.9.35) with SMTP id M2009020418344007933 for ; Wed, 04 Feb 2009 18:34:40 +0200 Message-ID: <4989C3FF.2040801@gentoo.org> Date: Wed, 04 Feb 2009 18:36:15 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; fi; rv:1.8.1.19) Gecko/20090111 Thunderbird/2.0.0.19 Mnenhy/0.7.5.666 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Announcement of The G Palmtop Environment ebuilds References: <1233675279.6250.95.camel@localhost> <4989827F.3000907@gentoo.org> <1233756207.22368.29.camel@localhost> In-Reply-To: <1233756207.22368.29.camel@localhost> X-Enigmail-Version: 0.95.7 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig21B101F8A17FCB8A2D963AD8" X-Archives-Salt: 44a3a551-9539-4e8f-8265-aaae693526ea X-Archives-Hash: 754ff1eaa9dad0b367d284667b5410c5 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig21B101F8A17FCB8A2D963AD8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Angelo Arrifano wrote: >=20 > # Copyright 2008 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Header: $ > # > # Authors: > # Rene Wagner > # Ned Ludd > # Angelo Arrifano >=20 Should use eclass-manpages syntax. >=20 > # GPE ECLASS > #GPECONF=3D"" # extra configure opts passed to econf > ELTCONF=3D"" # extra options passed to elibtoolize > DOCS=3D"" # documentation files to be installed with do= doc >=20 If other eclass that comes before in the inherit hierarchy and sets DOCS, do we want to override it? > [ -z "${GPE_MIRROR}" ] && export GPE_MIRROR=3D"http://gpe.linuxtogo.org= /download/source" >=20 > [ -z "${GPE_TARBALL_SUFFIX}" ] && export GPE_TARBALL_SUFFIX=3D"gz" >=20 Is there a binary called that makes use of those two? >=20 > IUSE=3D"${IUSE} nls" > This is the first use of IUSE in the eclass so there is nothing to append to. >=20 > gpe_src_configure() { > tc-export CC > if [ -f configure ]; then > elibtoolize ${ELTCONF} > econf "$@" ${GPECONF} || die "./configure failure" > fi > } >=20 Ebuilds/Eclasses should use [[ instead of [ and econf dies on it's own any way. > gpe_src_install() { > USE_NLS=3Dyes > use nls || USE_NLS=3Dno >=20 I don't see USE_NLS used outside install so it should be local and written in lower case. > if [ -f configure ]; then > einstall "$@" > else If you really need to use einstall, it would be best to add a comment about why it's needed. > make DESTDIR=3D${D} PREFIX=3D/usr \ > STRIP=3Dtrue ENABLE_NLS=3D${USE_NLS} \ > "$@" install > fi >=20 Should use emake. Stripping should be left to the package manager. > # manual document installation > [ -n "${DOCS}" ] && dodoc ${DOCS} >=20 > } >=20 dodoc should have || die with it > > EXPORT_FUNCTIONS src_compile src_install src_unpack >=20 Never exports configure for EAPI 2. Regards, Petteri --------------enig21B101F8A17FCB8A2D963AD8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmJxAIACgkQcxLzpIGCsLQLcQCgjtINlL6nm/n10zXftgrjFuz4 nW8AoJwRK2DAfdtK83BLjbHReD08YlWi =J13A -----END PGP SIGNATURE----- --------------enig21B101F8A17FCB8A2D963AD8--