From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LJWZN-0003Yd-Hq for garchives@archives.gentoo.org; Sun, 04 Jan 2009 17:15:21 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B0CBEE06C0; Sun, 4 Jan 2009 17:15:14 +0000 (UTC) Received: from out2.smtp.messagingengine.com (out2.smtp.messagingengine.com [66.111.4.26]) by pigeon.gentoo.org (Postfix) with ESMTP id 934A3E06C0 for ; Sun, 4 Jan 2009 17:15:14 +0000 (UTC) Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 52F7D2020EC for ; Sun, 4 Jan 2009 12:15:14 -0500 (EST) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 04 Jan 2009 12:15:14 -0500 X-Sasl-enc: woHlS0BgiAInBmP3jB1eCWLv2LMEySH4AYtzn4gq/d+L 1231089313 Received: from [192.168.188.1] (82-71-33-97.dsl.in-addr.zen.co.uk [82.71.33.97]) by mail.messagingengine.com (Postfix) with ESMTPSA id AE9FD2E4C9 for ; Sun, 4 Jan 2009 12:15:13 -0500 (EST) Message-ID: <4960EEA0.6060600@gentoo.org> Date: Sun, 04 Jan 2009 17:15:12 +0000 From: Mike Auty User-Agent: Thunderbird 2.0.0.19 (X11/20090102) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [v4] Planning for automatic assignment computation of bugs References: <20081019060114.GA21785@curie-int.orbis-terrarum.net> <200901041752.38316.rbu@gentoo.org> <4960EB9D.6030808@gentoo.org> <20090104180608.2e0935e5@epia.jer-c2.orkz.net> In-Reply-To: <20090104180608.2e0935e5@epia.jer-c2.orkz.net> X-Enigmail-Version: 0.95.7 Content-Type: multipart/mixed; boundary="------------050900050409070601020104" X-Archives-Salt: 20c7d4ba-eff5-4ace-a457-1fb47e20fbc8 X-Archives-Hash: 2b3b297cbd23c38b27d3f1b941703115 This is a multi-part message in MIME format. --------------050900050409070601020104 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jeroen Roovers wrote: > I spotted that too but didn't remember putting it in black and white. :) > > The order ("first maintainer as assignee" or "first maintainer/herd as > assignee") is open to discussion and I think this is the proper forum to > have that discussion. It seems sensible to me. I would've thought that being more specific would surely be better? Splitting them up means those who are mostly in charge of a package see it easily, and it's also then easier to spot packages that only have a herd, rather than them getting lost in all the packages that do have individual maintainers... I've attached a quick patch that should fix up assign.py to add all the herds on the end. Since the order of the second item onwards doesn't matter, all herds are added at the end. If we do need an ordering (like maintainer1, herd1, maintainer2, maintainer3, herd2) then it'll need a more complex patch... Hope this helps, Mike 5:) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAklg7p8ACgkQu7rWomwgFXoDwACcCDBD5Dj/F//7Bxq+zIB1/GPZ UHQAnA82J6UxuHva7uEXmEL9wuNDMkIk =SRmT -----END PGP SIGNATURE----- --------------050900050409070601020104 Content-Type: text/plain; name="assign-patch.py" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="assign-patch.py" diff --git a/assign.py b/assign.py index 82d894b..c7c2c59 100644 --- a/assign.py +++ b/assign.py @@ -54,6 +54,7 @@ def get_pkg_cat(string): def get_maintainer_for(directory): """ returns a priority-sorted list of maintainers for a given CAT or CAT/PN """ cc = [] + hcc = [] try: if not heXML: globals()['heXML'] = et.parse(HERDS) @@ -65,7 +66,7 @@ def get_maintainer_for(directory): if thisherd.findtext("name") == elem.text: herdmail = thisherd.findtext("email") if herdmail: - cc.append(herdmail) + hcc.append(herdmail) elif elem.tag == "maintainer": email = elem.findtext("email") if not email: @@ -75,6 +76,7 @@ def get_maintainer_for(directory): cc.remove(email) else: cc.append(email) + cc.extend(hcc) except Exception: pass --------------050900050409070601020104 Content-Type: application/octet-stream; name="assign-patch.py.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="assign-patch.py.sig" iEYEABECAAYFAklg7p8ACgkQu7rWomwgFXrJewCcC3YYza7eEvaq92FNecKQvmzhS3UAoIh2 uEQZkjAypZNtLcTIBQ8qT5sV --------------050900050409070601020104--