From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Kz0hD-00027i-MC for garchives@archives.gentoo.org; Sun, 09 Nov 2008 03:10:40 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7217FE02AC; Sun, 9 Nov 2008 03:10:38 +0000 (UTC) Received: from tommyserver.de (tommyserver.de [85.14.217.158]) by pigeon.gentoo.org (Postfix) with ESMTP id 416ECE02AC for ; Sun, 9 Nov 2008 03:10:38 +0000 (UTC) Received: from [192.168.178.22] (Q5cfb.q.pppool.de [89.53.92.251]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tommyserver.de (Postfix) with ESMTPSA id 68010FDDB8C for ; Sun, 9 Nov 2008 04:10:44 +0100 (CET) Message-ID: <491654A2.9020908@gentoo.org> Date: Sun, 09 Nov 2008 04:10:26 +0100 From: Thomas Sachau Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] DEFAULT_* proposal References: <20081108222051.GA7464@spoc> In-Reply-To: <20081108222051.GA7464@spoc> X-Enigmail-Version: 0.95.7 OpenPGP: id=211CA2D4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig3F1808AAE8E964509C671468" X-Archives-Salt: d443fb97-31fb-445d-a852-5204249479dc X-Archives-Hash: 935766b085562753f3676a4162d8327a This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3F1808AAE8E964509C671468 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thomas Anderson schrieb: > src_install: > All I want changed here is a variable for a list of extra docs to be= > installed. This'll require a default function for > src_install and I propose: > src_install() { > emake -j1 install DESTDIR=3D"${D}" || die "make install died" > [[ -n ${DEFAULT_SRC_INSTALL_DOCS} ]] && dodoc \ > ${DEFAULT_SRC_INSTALL_DOCS} > } > bug #33544 has more information on this topic, as does > tommy's recent thread on the subject of default src_install > function. At least for this one, why dont you use my proposal? -default should always be unlimited emake, so no -j1 -Why die, if emake fails because of missing makefile (as meta ebuilds ten= d to have)? -Why not check for some default docs and install them if they exist and m= ake dodoc die on error? this is at least, what my latest proposal does: src_install() { if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then emake DESTDIR=3D"${D}" install || die "emake install failed" fi if [ -n "${DOCS}" ]; then dodoc ${DOCS} || die "dodoc failed" else for x in AUTHORS ChangeLog NEWS README; do if [ -e ${x} ]; then dodoc ${x} || die "dodoc ${x} failed" fi done fi } The rest of the proposal looks acceptable to me. --=20 Thomas Sachau Gentoo Linux Developer --------------enig3F1808AAE8E964509C671468 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iJwEAQEKAAYFAkkWVKkACgkQG7kqcTWJkGfzPwP/RgS7poObJpOH4IVSO7g8/hZe LvB1gyt7wIqV5dw5JNhYg4TPVmXPU23eSOcznUKTrgmAtJQyOjasJt4NL+L4ci9q KxM+U9e3JkhBMjEC0vXaofI8Cjbo/o8R/V0peao62dWKkQjckbzJrXY2ayt0frH1 auGydOp9cRrDG10lfVQ= =5wJ4 -----END PGP SIGNATURE----- --------------enig3F1808AAE8E964509C671468--