From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KxorS-0003N9-O4 for garchives@archives.gentoo.org; Wed, 05 Nov 2008 20:20:18 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E1AA2E04C7; Wed, 5 Nov 2008 20:20:17 +0000 (UTC) Received: from tommyserver.de (tommyserver.de [85.14.217.158]) by pigeon.gentoo.org (Postfix) with ESMTP id B3D39E04C7 for ; Wed, 5 Nov 2008 20:20:17 +0000 (UTC) Received: from [192.168.178.22] (Q3f1b.q.pppool.de [89.53.63.27]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tommyserver.de (Postfix) with ESMTPSA id 5246870B99A for ; Wed, 5 Nov 2008 21:20:20 +0100 (CET) Message-ID: <4911FFF7.8030603@gentoo.org> Date: Wed, 05 Nov 2008 21:20:07 +0100 From: Thomas Sachau Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Proposed change to base.eclass: EAPI-2 support References: <200811022308.49072.loki_val@gentoo.org> <200811032053.59249.loki_val@gentoo.org> <4911E54D.6090008@gentoo.org> <200811051945.32471.loki_val@gentoo.org> In-Reply-To: <200811051945.32471.loki_val@gentoo.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=211CA2D4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigA9F9F2B50903113FF4814FB2" X-Archives-Salt: c6227b62-048b-4e47-8277-007c8890c68d X-Archives-Hash: c4bc8a62861193f35924539620534635 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA9F9F2B50903113FF4814FB2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Peter Alfredsen schrieb: > On Wednesday 05 November 2008, Thomas Sachau wrote: >=20 >> You should at least use emake instead of make in src_install. And i >> would suggest to use something like this instead of the make install >> line (maybe add some other default docs, if they are common): >> >> if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then >> emake DESTDIR=3D"${D}" install || die "emake install failed" >> fi >> if [ -n "${DOCS}" ]; then >> dodoc ${DOCS} || die "dodoc failed" >> else >> for x in AUTHORS ChangeLog NEWS README; do >> if [ -e ${x} ]; then >> dodoc ${x} || die "dodoc ${x} failed" >> fi >> done >> fi >=20 > I only propose changes to update the base.eclass to using EAPI-2=20 > functions, IOW the above is outside the scope of what I propose. >=20 > Besides, using emake instead of make is not a good change to make to an= =20 > eclass unless you know for a fact that all ebuilds using the eclass=20 > have parallel make friendly makefiles. And even then... >=20 So change your src_compile ;-) Do you really think, a package that supports parallel make while compilin= g fails support for parallel make support on install? And emake is and still should be the default. If there is an issue with i= t, the ebuild author has to change his ebuild. But this should not be taken to force only one makejob= for everyone else. --=20 Thomas Sachau Gentoo Linux Developer --------------enigA9F9F2B50903113FF4814FB2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iJwEAQEKAAYFAkkR//wACgkQG7kqcTWJkGd4qQP+OgHDfj1acXNBX7s3y4ZGenR1 RX0aAZNFPh2CqcSF99mt3u6fBhhzFn3h8MJ/B5dkkF5unriT2aoVJBs4e37mmK96 xuAYixtnqZKkXvnwdoXbiw4gHKjGVT3rm/WSi31L28vuMcngsdLfvoXxgonHOliM LurO5pqJw/kK38aGnhU= =VTCI -----END PGP SIGNATURE----- --------------enigA9F9F2B50903113FF4814FB2--