From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Kxn5O-0003dm-PJ for garchives@archives.gentoo.org; Wed, 05 Nov 2008 18:26:34 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 01777E0521; Wed, 5 Nov 2008 18:26:35 +0000 (UTC) Received: from tommyserver.de (tommyserver.de [85.14.217.158]) by pigeon.gentoo.org (Postfix) with ESMTP id CFE5CE0521 for ; Wed, 5 Nov 2008 18:26:34 +0000 (UTC) Received: from [192.168.178.22] (Q3f1b.q.pppool.de [89.53.63.27]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tommyserver.de (Postfix) with ESMTPSA id CAA3070BACE for ; Wed, 5 Nov 2008 19:26:35 +0100 (CET) Message-ID: <4911E54D.6090008@gentoo.org> Date: Wed, 05 Nov 2008 19:26:21 +0100 From: Thomas Sachau Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Proposed change to base.eclass: EAPI-2 support References: <200811022308.49072.loki_val@gentoo.org> <200811030700.34515.loki_val@gentoo.org> <200811032053.59249.loki_val@gentoo.org> In-Reply-To: <200811032053.59249.loki_val@gentoo.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=211CA2D4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig6F10BE8942FF370F00A59808" X-Archives-Salt: f4b30287-3a24-411d-a1ee-849d65f6dd8a X-Archives-Hash: 5b9c91cbebc122b389779690f66974a1 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6F10BE8942FF370F00A59808 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Peter Alfredsen schrieb: > On Monday 03 November 2008, Steve Long wrote: >> Peter Alfredsen wrote: >>> debug-print-function $FUNCNAME $* >> You should be using "$@" not unquoted $*. >=20 > Fixed. Also fixed base_src_unpack and base_src_compile calling their=20 > grunt functions with $1, when clearly it should have been $@. >=20 >> Seems like the FUNCNAME bit should just be rolled into the function >> with "${FUNCNAME[1]}" which could be done tree-wide quite easily. >=20 > I guess that function was written before bash-3 when FUNCNAME was turne= d=20 > into an array. >=20 >=20 >=20 You should at least use emake instead of make in src_install. And i would= suggest to use something like this instead of the make install line (maybe add some other default = docs, if they are common): if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then emake DESTDIR=3D"${D}" install || die "emake install failed" fi if [ -n "${DOCS}" ]; then dodoc ${DOCS} || die "dodoc failed" else for x in AUTHORS ChangeLog NEWS README; do if [ -e ${x} ]; then dodoc ${x} || die "dodoc ${x} failed" fi done fi --=20 Thomas Sachau Gentoo Linux Developer --------------enig6F10BE8942FF370F00A59808 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iJwEAQEKAAYFAkkR5VUACgkQG7kqcTWJkGc4cQQAjFXdQ4JbTlynJjveQHsE3wrB mXtxQVvv5O4cvVCC9CFPjhNf/ipV184spb0rpbgKje6heytlm88Tdj2F3eSodT8F mJYbLQwM5aiWUKck90bXWKzlqHcfXosuDIIH9C1KZqB8Y3vLfmJiNmE9Fkb5ygNg y+tUOcjGtm9KOS1V/9o= =SAO/ -----END PGP SIGNATURE----- --------------enig6F10BE8942FF370F00A59808--