From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-32821-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1KhD7E-0002VE-F6
	for garchives@archives.gentoo.org; Sun, 21 Sep 2008 00:47:56 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 7FB20E066D;
	Sun, 21 Sep 2008 00:47:55 +0000 (UTC)
Received: from tommyserver.de (tommyserver.de [85.14.217.158])
	by pigeon.gentoo.org (Postfix) with ESMTP id 5B177E066D
	for <gentoo-dev@lists.gentoo.org>; Sun, 21 Sep 2008 00:47:55 +0000 (UTC)
Received: from [192.168.178.22] (Q2806.q.pppool.de [89.53.40.6])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by tommyserver.de (Postfix) with ESMTPSA id 6F665BC5395
	for <gentoo-dev@lists.gentoo.org>; Sun, 21 Sep 2008 02:47:51 +0200 (CEST)
Message-ID: <48D599AD.20605@gentoo.org>
Date: Sun, 21 Sep 2008 02:47:41 +0200
From: Thomas Sachau <tommy@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI
References: <20080916000101.GJ6035@curie-int.orbis-terrarum.net> <48D4DEF8.10202@gentoo.org> <48D54A08.7050603@gentoo.org>
In-Reply-To: <48D54A08.7050603@gentoo.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=211CA2D4
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="------------enig6C234507134BFE1905CA02A5"
X-Archives-Salt: ade3f343-e01c-4c27-957e-17c86bef976c
X-Archives-Hash: 2936ab7632c6c08f7b4bf14f10c9f6bc

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig6C234507134BFE1905CA02A5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Petteri R=C3=A4ty schrieb:
> Thomas Sachau kirjoitti:
>> I see, we have a default src_unpack and a default src_compile but a
>> default src_install is still
>> missing. Here is my suggestion (taken and modified from bug 33544):
>>
>> src_install() {
>>     if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
>>         emake DESTDIR=3D${D} install || die "emake install failed"
>>         [[ -n ${DOCS} ]] && dodoc ${DOCS}
>>     else
>>         einstall || die "einstall failed"
>>         [[ -n ${DOCS} ]] && dodoc ${DOCS}
>>     fi
>> }
>>
>> Any comments?
>>
>=20
> einstall uses make so doesn't really make sense.
>=20
> Regards,
> Petteri
>=20

updated version:


src_install() {
	if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
		emake DESTDIR=3D"${D}" install || einstall
		if [[ $?>0 ]]; then
			die "install failed"
		else
			if [[ -n ${DOCS} ]]; then
				dodoc ${DOCS} || die "dodoc failed"
			fi
		fi
	fi
}


--------------enig6C234507134BFE1905CA02A5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iJwEAQEKAAYFAkjVmbgACgkQG7kqcTWJkGf7FAQAvc3EvMSHsXA2VfIXzH9Jg/Rk
FtK56zUVXe73HuxRNkXhCRWSDrzBcN0xEuLw+Y8PxNyuUViwMRO0lsbsHt2iFjqH
Fz0uBql3+ksivCgbIToBMTcaj4LZLsz/+QYc1z0ZLpS0d496RfqAjDT05seCbzw5
KXls/HWTQi9U6mjrj0g=
=ffoZ
-----END PGP SIGNATURE-----

--------------enig6C234507134BFE1905CA02A5--