public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] unwanted CVS keyword substitution on patch files
@ 2008-08-16 10:26 Alin Năstac
  2008-08-16 10:50 ` [gentoo-dev] " Zac Medico
  0 siblings, 1 reply; 2+ messages in thread
From: Alin Năstac @ 2008-08-16 10:26 UTC (permalink / raw
  To: Gentoo Dev

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

Every once in a while, I get bitten by the $Id keyword replacement done
on patches in $FILESDIR.

Can we do something to fix this annoyance? If repoman cannot add -kb for
*.patch and *.diff files, at least it should verify you have added those
files with this options.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [gentoo-dev] Re: unwanted CVS keyword substitution on patch files
  2008-08-16 10:26 [gentoo-dev] unwanted CVS keyword substitution on patch files Alin Năstac
@ 2008-08-16 10:50 ` Zac Medico
  0 siblings, 0 replies; 2+ messages in thread
From: Zac Medico @ 2008-08-16 10:50 UTC (permalink / raw
  To: Gentoo Dev; +Cc: Alin Năstac

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alin Năstac wrote:
> Every once in a while, I get bitten by the $Id keyword replacement done
> on patches in $FILESDIR.
> 
> Can we do something to fix this annoyance? If repoman cannot add -kb for
> *.patch and *.diff files, at least it should verify you have added those
> files with this options.
> 

Yes, we can fix that. The code to identify which ones were added
with -kb is already there. We just have to make it search for the
$Id keyword in all the new/updated files and filter out any that
have the -kb flag set. I guess we could have it bail out in that
case or else re-add it with the -kb flag set.
- --
Thanks,
Zac
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAkimsQcACgkQ/ejvha5XGaMLNQCgizBZYN8oJRvB4La9qAWbnJWy
T/UAoOe5m+OaHR5TIo6vIWllX3ezzgBs
=uaiP
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-16 10:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-16 10:26 [gentoo-dev] unwanted CVS keyword substitution on patch files Alin Năstac
2008-08-16 10:50 ` [gentoo-dev] " Zac Medico

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox