From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 844F115800A for ; Fri, 14 Jul 2023 16:19:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 662D0E08F7; Fri, 14 Jul 2023 16:19:24 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 232C1E08F2 for ; Fri, 14 Jul 2023 16:19:24 +0000 (UTC) Message-ID: <48968b07-9cf6-a867-7c71-d1920f16ead8@gentoo.org> Date: Fri, 14 Jul 2023 19:19:18 +0300 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [gentoo-dev] Re: [PATCH] ruby-utils.eclass: Simplify _ruby_implementation_depend Content-Language: en-US To: gentoo-dev@lists.gentoo.org, Sam James References: <20230714083427.467176-1-sam@gentoo.org> <877cr228h9.fsf@gentoo.org> From: Arthur Zamarin In-Reply-To: <877cr228h9.fsf@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------q2A98vXnql4YKtsug2O7bYQu" X-Archives-Salt: 03a9268c-cb28-4fed-8e96-473f087270a1 X-Archives-Hash: 755929af95144d4570bd2694a20e8362 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------q2A98vXnql4YKtsug2O7bYQu Content-Type: multipart/mixed; boundary="------------8vzbZVxoNfjH1X5oVldiWIN9"; protected-headers="v1" From: Arthur Zamarin To: gentoo-dev@lists.gentoo.org, Sam James Message-ID: <48968b07-9cf6-a867-7c71-d1920f16ead8@gentoo.org> Subject: Re: [gentoo-dev] Re: [PATCH] ruby-utils.eclass: Simplify _ruby_implementation_depend References: <20230714083427.467176-1-sam@gentoo.org> <877cr228h9.fsf@gentoo.org> In-Reply-To: <877cr228h9.fsf@gentoo.org> --------------8vzbZVxoNfjH1X5oVldiWIN9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 14/07/2023 11.37, Sam James wrote: >=20 > Sam James writes: >=20 >> From: konsolebox >> >> Closes: https://bugs.gentoo.org/909529 >> Signed-off-by: Sam James >=20 > ftr, while I find the case really repetitive, I'm not sure if this > crosses the line into unreadable bash or not, so I feel on the fence. >=20 > But I wanted it reviewed on ML in any case, rather than us forgetting > it on BZ. >=20 I agree the code isn't easy to read, but it isn't too hard. I do want to suggest you add a simple comment on the same line bringing an example value for the rubyslot. With an example comment, it becomes trivial to understand (and if someone needs to change it, he know beforehand what format to expect). --=20 Arthur Zamarin arthurzam@gentoo.org Gentoo Linux developer (Python, pkgcore stack, Arch Teams, GURU) --------------8vzbZVxoNfjH1X5oVldiWIN9-- --------------q2A98vXnql4YKtsug2O7bYQu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE/axFlFuH2ptjtO5EAqCvUD0SBQQFAmSxdYYACgkQAqCvUD0S BQTnfwf/ZsmdV6dvs0oEHTpYc/Vrk67YIGUZTa55fqZNCplcvujdobwegFCBTsGJ VoJ8Py2VPLuHXlAIX/PO9vHSvwsBxFKG4Stm0tdmVtyfC0N8RzK/zpvE9qsnACbQ CPE6u+oADa5r9aVSrQZ7wz7dcD2atappdPHaANPzxRDsixNKbWo/4Jgg6+WE58AF HnMCEbOv8YUFuMm8lumZwv1NmbdPrFls/sqW0C4TyZatLkUaX/E+ud6MBGLyLcaH Bqw+58iKHJoyDsK1p4YB4ufMt7lhYMuuARxIcil+ZI5dF8Yo+j/NP4ZLhJyDH7kO a6GKIkYn6BDb1mkcXKiW1ybMBGghsg== =xGF0 -----END PGP SIGNATURE----- --------------q2A98vXnql4YKtsug2O7bYQu--