Re: [gentoo-dev] Re: [PATCH] ruby-utils.eclass: Simplify _ruby_implementation_depend

[Arthur Zamarin <arthurzam@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 887 bytes --]

On 14/07/2023 11.37, Sam James wrote:
> 
> Sam James <sam@gentoo.org> writes:
> 
>> From: konsolebox <konsolebox@gmail.com>
>>
>> Closes: https://bugs.gentoo.org/909529
>> Signed-off-by: Sam James <sam@gentoo.org>
> 
> ftr, while I find the case really repetitive, I'm not sure if this
> crosses the line into unreadable bash or not, so I feel on the fence.
> 
> But I wanted it reviewed on ML in any case, rather than us forgetting
> it on BZ.
> 

I agree the code isn't easy to read, but it isn't too hard. I do want to
suggest you add a simple comment on the same line bringing an example
value for the rubyslot. With an example comment, it becomes trivial to
understand (and if someone needs to change it, he know beforehand what
format to expect).

-- 
Arthur Zamarin
arthurzam@gentoo.org
Gentoo Linux developer (Python, pkgcore stack, Arch Teams, GURU)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]