[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Donnie Berkholz]

On 19:37 Sat 29 Mar     , Saleem Abdulrasool (compnerd) wrote:
> 1.1                  app-editors/leafpad/leafpad-0.8.14.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/leafpad/leafpad-0.8.14.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/leafpad/leafpad-0.8.14.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	econf --enable-chooser --enable-print $(use_enable emacs)
> 	emake
> }

emake doesn't die on failure.

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Ulrich Mueller]

>>>>> On Sat, 29 Mar 2008, Donnie Berkholz wrote:

> On 19:37 Sat 29 Mar     , Saleem Abdulrasool (compnerd) wrote:
>> 1.1                  app-editors/leafpad/leafpad-0.8.14.ebuild

>> src_compile() {
>> 	econf --enable-chooser --enable-print $(use_enable emacs)
>> 	emake
>> }

> emake doesn't die on failure.

And IMHO the "emacs" USE flag should not be used here:

   $ ./configure -hs
   Configuration of Leafpad 0.8.12:

   Optional Features:
   [...]
     --enable-emacs          implement Emacs key theme (experimental)

   $ equery uses =leafpad-0.8.12
   [...]
    + + emacs : Adds support for GNU Emacs

As its description says, the flag is intended for GNU Emacs support
which is not the case here.

Ulrich
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

On Sunday 30 March 2008, Ulrich Mueller wrote:
> >>>>> On Sat, 29 Mar 2008, Donnie Berkholz wrote:
> >
> > On 19:37 Sat 29 Mar     , Saleem Abdulrasool (compnerd) wrote:
> >> 1.1                  app-editors/leafpad/leafpad-0.8.14.ebuild
> >>
> >> src_compile() {
> >> 	econf --enable-chooser --enable-print $(use_enable emacs)
> >> 	emake
> >> }
> >
> > emake doesn't die on failure.
>
> And IMHO the "emacs" USE flag should not be used here:
>
>    $ ./configure -hs
>    Configuration of Leafpad 0.8.12:
>
>    Optional Features:
>    [...]
>      --enable-emacs          implement Emacs key theme (experimental)
>
>    $ equery uses =leafpad-0.8.12
>    [...]
>     + + emacs : Adds support for GNU Emacs
>
> As its description says, the flag is intended for GNU Emacs support
> which is not the case here.

i think the USE flag makes sense.  perhaps the description should be changed.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Ulrich Mueller]

>>>>> On Sun, 30 Mar 2008, Mike Frysinger wrote:

>> And IMHO the "emacs" USE flag should not be used here:
>> 
>> $ ./configure -hs
>> Configuration of Leafpad 0.8.12:
>> 
>> Optional Features:
>> [...]
>> --enable-emacs          implement Emacs key theme (experimental)
>> 
>> $ equery uses =leafpad-0.8.12
>> [...]
>> + + emacs : Adds support for GNU Emacs
>> 
>> As its description says, the flag is intended for GNU Emacs support
>> which is not the case here.

> i think the USE flag makes sense. perhaps the description should be
> changed.

Certainly a USE flag makes sense here, but it shouldn't be USE=emacs.

The "emacs" global USE flag is used by 82 other packages (all outside
the app-emacs category). Its purpose is always that GNU Emacs specific
files are installed; either directly, or indirectly by pulling another
package via *DEPEND.

So leafpad would be the first package assigning a different meaning to
the flag.

In my opinion, a local USE flag like "emacskeys" or "emacs-keymap"
would make more sense here. (And I doubt that users who would enable
Emacs key bindings in leafpad would always want GNU Emacs. Setting
USE=emacs in make.conf will inevitably install it.)

Ulrich
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

On Sunday 30 March 2008, Ulrich Mueller wrote:
> >>>>> On Sun, 30 Mar 2008, Mike Frysinger wrote:
> >>
> >> And IMHO the "emacs" USE flag should not be used here:
> >>
> >> $ ./configure -hs
> >> Configuration of Leafpad 0.8.12:
> >>
> >> Optional Features:
> >> [...]
> >> --enable-emacs          implement Emacs key theme (experimental)
> >>
> >> $ equery uses =leafpad-0.8.12
> >> [...]
> >> + + emacs : Adds support for GNU Emacs
> >>
> >> As its description says, the flag is intended for GNU Emacs support
> >> which is not the case here.
> >
> > i think the USE flag makes sense. perhaps the description should be
> > changed.
>
> Certainly a USE flag makes sense here, but it shouldn't be USE=emacs.
>
> The "emacs" global USE flag is used by 82 other packages (all outside
> the app-emacs category). Its purpose is always that GNU Emacs specific
> files are installed; either directly, or indirectly by pulling another
> package via *DEPEND.

why cant it mean both ?  USE flags are intended to control features, not 
dependencies.  often times that just happens to translate into dependencies.  
realistically though, anyone who wants "emacs" wants all emacs "things".  if 
it were to just pull in the emacs dependency, then that could just as easily 
be accomplished by `emerge emacs` and then we can drop the USE flag entirely.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Marijn Schouten (hkBst)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mike Frysinger wrote:
| On Sunday 30 March 2008, Ulrich Mueller wrote:
|>>>>>> On Sun, 30 Mar 2008, Mike Frysinger wrote:
|>>> And IMHO the "emacs" USE flag should not be used here:
|>>>
|>>> $ ./configure -hs
|>>> Configuration of Leafpad 0.8.12:
|>>>
|>>> Optional Features:
|>>> [...]
|>>> --enable-emacs          implement Emacs key theme (experimental)
|>>>
|>>> $ equery uses =leafpad-0.8.12
|>>> [...]
|>>> + + emacs : Adds support for GNU Emacs
|>>>
|>>> As its description says, the flag is intended for GNU Emacs support
|>>> which is not the case here.
|>> i think the USE flag makes sense. perhaps the description should be
|>> changed.
|> Certainly a USE flag makes sense here, but it shouldn't be USE=emacs.
|>
|> The "emacs" global USE flag is used by 82 other packages (all outside
|> the app-emacs category). Its purpose is always that GNU Emacs specific
|> files are installed; either directly, or indirectly by pulling another
|> package via *DEPEND.
|
| why cant it mean both ?  USE flags are intended to control features, not
| dependencies.  often times that just happens to translate into dependencies.
| realistically though, anyone who wants "emacs" wants all emacs "things".  if
| it were to just pull in the emacs dependency, then that could just as easily
| be accomplished by `emerge emacs` and then we can drop the USE flag entirely.
| -mike

If this in an emacs thing, then I guess it includes its own emacs-compatible elisp
implementation with editor primitives exported to the user? Otherwise customizability is
something of a laugh. Keybindings can be rewired. Simply having the same default
keybindings as emacs does not make a package emacsy.

Seeing as this is an editor and a "GTK+ based simple text editor" I doubt it has much
claim to emacs-ness.

If my explanation doesn't make any sense to anyone, please trust our emacs team's
judgement in this.

Marijn

- --
Marijn Schouten (hkBst), Gentoo Lisp project, Gentoo ML
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-{lisp,ml} on FreeNode
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkfwhCAACgkQp/VmCx0OL2yXPgCcD2K/7QKMe1V6S2mmXNRj213n
KmkAoJs7Tdrgka4Hgm33AdplqtTf+MH+
=4jAE
-----END PGP SIGNATURE-----
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]

On Monday 31 March 2008, Marijn Schouten (hkBst) wrote:
> Mike Frysinger wrote:
> | On Sunday 30 March 2008, Ulrich Mueller wrote:
> |>>>>>> On Sun, 30 Mar 2008, Mike Frysinger wrote:
> |>>>
> |>>> And IMHO the "emacs" USE flag should not be used here:
> |>>>
> |>>> $ ./configure -hs
> |>>> Configuration of Leafpad 0.8.12:
> |>>>
> |>>> Optional Features:
> |>>> [...]
> |>>> --enable-emacs          implement Emacs key theme (experimental)
> |>>>
> |>>> $ equery uses =leafpad-0.8.12
> |>>> [...]
> |>>> + + emacs : Adds support for GNU Emacs
> |>>>
> |>>> As its description says, the flag is intended for GNU Emacs support
> |>>> which is not the case here.
> |>>
> |>> i think the USE flag makes sense. perhaps the description should be
> |>> changed.
> |>
> |> Certainly a USE flag makes sense here, but it shouldn't be USE=emacs.
> |>
> |> The "emacs" global USE flag is used by 82 other packages (all outside
> |> the app-emacs category). Its purpose is always that GNU Emacs specific
> |> files are installed; either directly, or indirectly by pulling another
> |> package via *DEPEND.
> |
> | why cant it mean both ?  USE flags are intended to control features, not
> | dependencies.  often times that just happens to translate into
> | dependencies. realistically though, anyone who wants "emacs" wants all
> | emacs "things".  if it were to just pull in the emacs dependency, then
> | that could just as easily be accomplished by `emerge emacs` and then we
> | can drop the USE flag entirely. -mike
>
> If this in an emacs thing, then I guess it includes its own
> emacs-compatible elisp implementation with editor primitives exported to
> the user? Otherwise customizability is something of a laugh. Keybindings
> can be rewired. Simply having the same default keybindings as emacs does
> not make a package emacsy.
>
> Seeing as this is an editor and a "GTK+ based simple text editor" I doubt
> it has much claim to emacs-ness.

why does this matter ?  if an application includes optional support for 
an "emacs skin" such that it includes emacs bindings/shortcuts/whatever, it 
sounds to me like USE=emacs is appropriate.  ive seen random applications 
that have different keybinding modes have the default set, and then optional 
vi or emacs to select from so that things behave as such users would expect.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild

[Christian Faulhammer]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

Hi,

Mike Frysinger <vapier@gentoo.org>:
> > Seeing as this is an editor and a "GTK+ based simple text editor" I
> > doubt it has much claim to emacs-ness.
> 
> why does this matter ?  if an application includes optional support
> for an "emacs skin" such that it includes emacs
> bindings/shortcuts/whatever, it sounds to me like USE=emacs is
> appropriate.  ive seen random applications that have different
> keybinding modes have the default set, and then optional vi or emacs
> to select from so that things behave as such users would expect. -mike
 
 We have USE=xemacs and emacs...and the key bindings for above editor
will switch to something that is also compatible with XEmacs.  So why
shouldn't one choose USE=xemacs here?  We, XEmacs and GNU Emacs team,
understand "our" USE flags as integration with said editors not
something to mimick their behaviour.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]