[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox: ChangeLog rox-2.7-r2.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox: ChangeLog rox-2.7-r2.ebuild

[Donnie Berkholz]

On 15:05 Mon 17 Dec     , Jim Ramsay (lack) wrote:
> lack        07/12/17 15:05:57
> 
>   Modified:             ChangeLog
>   Added:                rox-2.7-r2.ebuild
>   Log:
>   Started using EAPI=1 and IUSE defaults.  Also added new 'video' flag to IUSE (bug 202333)
>   (Portage version: 2.1.3.19)

> 1.1                  rox-base/rox/rox-2.7-r2.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/rox-base/rox/rox-2.7-r2.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/rox-base/rox/rox-2.7-r2.ebuild?rev=1.1&content-type=text/plain

> IUSE="+svg +video"

svg already defaults on for all the desktop profiles, so I'm not really 
sure what that's gaining you.

> RDEPEND=">=x11-libs/gtk+-2.4
> 	>=dev-libs/glib-2.2
> 	>=dev-libs/libxml2-2.4.23
> 	>=x11-misc/shared-mime-info-0.14
> 	svg? ( gnome-base/librsvg )
> 	!ppc? ( rox-base/mime-editor
> 		rox-base/thumbs
> 		video? ( rox-extra/videothumbnail ) )"

PPC users aren't supposed to get this stuff? If not, is it even a real 
dependency?

> src_compile() {
> 
> 	cd ${APPNAME}
> 
> 	# Most rox self-compiles have a 'read' call to wait for the user to
> 	# press return if the compile fails.
> 	# Find and remove this:
> 	sed -i.bak -e 's/\<read WAIT\>/#read/' AppRun
> 
> 	./AppRun --compile || die "make failed"
> 	(cd src; make clean) > /dev/null
> 	# don't need these directories anymore
> 	if [ -n "${KEEP_SRC}" ]; then
> 		(cd src; make clean) > /dev/null

Subshells are icky.

> 	else
> 		rm -rf src
> 	fi
> 	rm -fr build
> 
> 	# Restore the original AppRun
> 	mv AppRun.bak AppRun
> }
> 
> # new streamlined install
> 
> src_install() {
> 	doman rox.1
> 
> 	dodir ${APPDIR}
> 	cp -r ${APPNAME}/ "${D}/${APPDIR}"
> 
> 	# add documentation to be proper
> 	( cd ${APPNAME}/Help
> 	dodoc Changes README README-es TODO
> 	)

Icky.

> 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}"
> 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}uri"

fperms?

> 	make_desktop_entry ${WRAPPERNAME} ${APPNAME} ${APPNAME}.png "System;Utility;Core;ROX"

Thought I saw something about desktop entries dropping the suffix for 
the icon, but I don't recall the details.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox: ChangeLog rox-2.7-r2.ebuild

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Donnie Berkholz kirjoitti:

> Icky.
> 
>> 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}"
>> 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}uri"
> 
> fperms?
> 
>> 	make_desktop_entry ${WRAPPERNAME} ${APPNAME} ${APPNAME}.png "System;Utility;Core;ROX"
> 
> Thought I saw something about desktop entries dropping the suffix for 
> the icon, but I don't recall the details.
> 

Yeah, the spec says the values should not have the suffix. Should
probably make make_desktop_entry run desktop-file-validate if installed.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox: ChangeLog rox-2.7-r2.ebuild

[Jim Ramsay]

[-- Attachment #1: Type: text/plain, Size: 2034 bytes --]

Donnie Berkholz <dberkholz@gentoo.org> wrote:
> On 15:05 Mon 17 Dec     , Jim Ramsay (lack) wrote:
> > lack        07/12/17 15:05:57
> > IUSE="+svg +video"
> 
> svg already defaults on for all the desktop profiles, so I'm not
> really sure what that's gaining you.

Good point, removed '+' there

> > RDEPEND=">=x11-libs/gtk+-2.4
> > 	>=dev-libs/glib-2.2
> > 	>=dev-libs/libxml2-2.4.23
> > 	>=x11-misc/shared-mime-info-0.14
> > 	svg? ( gnome-base/librsvg )
> > 	!ppc? ( rox-base/mime-editor
> > 		rox-base/thumbs
> > 		video? ( rox-extra/videothumbnail ) )"
> 
> PPC users aren't supposed to get this stuff? If not, is it even a
> real dependency?

I'm waiting on bug 201983 for ppc to keyword those ebuilds.  They are
semi-optional runtime dependencies.  I'll explain further:

There are buttons in the ROX application's "options" window which
launch each of these applications.  Thus they are not *strictly*
required for basic operation, but are required for all the buttons in
the app to actually work.  videothumbnail is USE-dependent because it
needs either mplayer or totem, neither of which are very quick to
install.  The other two however (mime-editor and thumbs) are reasonably
simple python apps that really only take a second or so to download and
install.

> > 		(cd src; make clean) > /dev/null
> 
> Subshells are icky.

I agree, replaced them all with pushd/popd instead.

> > 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}"
> > 	chmod 0755 "${D}/usr/bin/${WRAPPERNAME}uri"
> 
> fperms?

Ah yes.  Done.
 
> > 	make_desktop_entry ${WRAPPERNAME} ${APPNAME} ${APPNAME}.png
> > "System;Utility;Core;ROX"
> 
> Thought I saw something about desktop entries dropping the suffix for 
> the icon, but I don't recall the details.

Yes, this is correct.  I have removed it.  Also technically speaking
there is no 'ROX' category (any more?) so I have removed it as well and
made it better match the defined menu categories.

-- 
Jim Ramsay
Gentoo/Linux Developer (rox,gkrellm)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox: ChangeLog rox-2.7-r2.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On Thursday 20 December 2007, Donnie Berkholz wrote:
> On 15:05 Mon 17 Dec     , Jim Ramsay (lack) wrote:
> >   Added:                rox-2.7-r2.ebuild
> >
> > IUSE="+svg +video"
>
> svg already defaults on for all the desktop profiles, so I'm not really
> sure what that's gaining you.

today for a subset of profiles.  tomorrow ?  other profiles ?  i dont think 
duplication here is a big deal and the point of IUSE defaults is so these 
defaults can be in the package and not worry about the profile
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]