From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9B794158086 for ; Tue, 4 Jan 2022 22:55:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3D5E02BC048; Tue, 4 Jan 2022 22:55:25 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 54FB22BC004 for ; Tue, 4 Jan 2022 22:55:24 +0000 (UTC) Content-Type: multipart/signed; boundary="Apple-Mail=_550215B2-8164-4B52-9351-02681513C92D"; protocol="application/pgp-signature"; micalg=pgp-sha512 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: [gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux" From: Sam James In-Reply-To: <0bf00be741c0ddc2a2d8b5e5b6b3852097cfb079.camel@gentoo.org> Date: Tue, 4 Jan 2022 22:55:15 +0000 Cc: gentoo-dev@lists.gentoo.org, kernel@gentoo.org Message-Id: <47675B8F-A813-4A13-BDC3-77246B8C2B60@gentoo.org> References: <20220104102348.221452-1-sam@gentoo.org> <0bf00be741c0ddc2a2d8b5e5b6b3852097cfb079.camel@gentoo.org> To: =?utf-8?B?TWljaGHFgiBHw7Nybnk=?= X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Archives-Salt: 26696c73-389e-4837-b5db-4f1738c56565 X-Archives-Hash: e5c6354defdec464eb8414d6ef202015 --Apple-Mail=_550215B2-8164-4B52-9351-02681513C92D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 4 Jan 2022, at 21:54, Micha=C5=82 G=C3=B3rny = wrote: >=20 > On Tue, 2022-01-04 at 11:17 -0500, Mike Gilbert wrote: >> On Tue, Jan 4, 2022 at 5:23 AM Sam James wrote: >>>=20 >>> It's already an implicit IUSE, so we don't need this. >>=20 >> I think it is better to declare it explicitly rather than relying on >> the IUSE_IMPLICIT setting in profiles. >=20 > I agree. Perhaps we should go even further and remove them from > implicit flags. >=20 (Note: I did push this change already to coalesce this with FreeBSD and other removals.) I don't think declaring it explicitly is helpful given in most cases (and even more now after recent cleanups), it's relied upon without declaring it anyway. Use within IUSE while it's implicit also means IUSE seems to regularly get out of sync with actual use within the ebuilds. As for removing implicit use entirely: while you might argue this could be okay for the Linux kernel, it would cause unnecessary rebuilds indefinitely whenever we add a new dep to an ebuild for e.g. Darwin, or if we did it for libcs, for say, musl/non-glibc. best, sam --Apple-Mail=_550215B2-8164-4B52-9351-02681513C92D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmHU0FNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDu7TAgAlDEUNLAiBK6+MMxi2KoITE4+UC8vwE9Wz04B3rbNvRLT2AT/B37JikeF iGUmIZljG4ypGTKeobOVWsjP3hPP18Zpuvl0/1koQiBwFs+MYYWfxhuNT+SNZIIT otGxTx6vOQNEl2PQ2ZRmEKKlJZn7n7aia7wn1wNMCkcsDKQ5qPA7ACkI8pbREZ4C Sf0sSrghNi4S4BWaah9q1m/TZAD1JzHN71x0SXsY2VYXoEVaXh6XkGmMXRNLV0To fkBNWx8I0O2RSQ/Q+PusVPPy4SsDxKLFZe41oEusE6MVrvv7uZQ+Yp/aoR9W8s9X 2/SuuNZmQvs7Vhc8qBracwjf9RjyaA== =ul8C -----END PGP SIGNATURE----- --Apple-Mail=_550215B2-8164-4B52-9351-02681513C92D--