Re: [gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux"

[Sam James <sam@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]



> On 4 Jan 2022, at 21:54, Michał Górny <mgorny@gentoo.org> wrote:
> 
> On Tue, 2022-01-04 at 11:17 -0500, Mike Gilbert wrote:
>> On Tue, Jan 4, 2022 at 5:23 AM Sam James <sam@gentoo.org> wrote:
>>> 
>>> It's already an implicit IUSE, so we don't need this.
>> 
>> I think it is better to declare it explicitly rather than relying on
>> the IUSE_IMPLICIT setting in profiles.
> 
> I agree.  Perhaps we should go even further and remove them from
> implicit flags.
> 

(Note: I did push this change already to coalesce this
with FreeBSD and other removals.)

I don't think declaring it explicitly is helpful given
in most cases (and even more now after recent
cleanups), it's relied upon without declaring it anyway.

Use within IUSE while it's implicit also means
IUSE seems to regularly get out of sync with
actual use within the ebuilds.

As for removing implicit use entirely: while you might
argue this could be okay for the Linux kernel, it would cause
unnecessary rebuilds indefinitely whenever we add a new dep
to an ebuild for e.g. Darwin, or if we did it for libcs,
for say, musl/non-glibc.

best,
sam

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]