From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1EDFC158015 for ; Sat, 30 Dec 2023 16:15:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8A0892BC041; Sat, 30 Dec 2023 16:15:25 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 51C762BC027 for ; Sat, 30 Dec 2023 16:15:25 +0000 (UTC) Message-ID: <474ea0d561577fbf2b77616352bc40b109f6892b.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 2/2] linux-mod-r1.eclass: Explicitly check for missing zstd From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Sat, 30 Dec 2023 17:15:20 +0100 In-Reply-To: References: <20231230050716.127184-1-mgorny@gentoo.org> <20231230050716.127184-2-mgorny@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-eV2/zVrvo+jT3iJ+sRgH" User-Agent: Evolution 3.50.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 75b24476-e8dc-4b1e-93e9-623501a46d7c X-Archives-Hash: 94033b108655486b7baa0358d5358409 --=-eV2/zVrvo+jT3iJ+sRgH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2023-12-30 at 10:27 -0500, Ionen Wolkens wrote: > On Sat, Dec 30, 2023 at 06:07:16AM +0100, Micha=C5=82 G=C3=B3rny wrote: > > Signed-off-by: Micha=C5=82 G=C3=B3rny > > --- > > eclass/linux-mod-r1.eclass | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/eclass/linux-mod-r1.eclass b/eclass/linux-mod-r1.eclass > > index b6be4ba8a16d..4de2e3f89995 100644 > > --- a/eclass/linux-mod-r1.eclass > > +++ b/eclass/linux-mod-r1.eclass > > @@ -855,6 +855,9 @@ _modules_process_compress() { > > compress=3D(gzip) > > fi > > elif linux_chkconfig_present MODULE_COMPRESS_ZSTD; then > > + if ! type -P zstd &>/dev/null; then > > + die "zstd not found, please install app-arch/zstd or disable USE=3D= modules-compress" > > + fi >=20 > As mentioned on IRC, I don't think we overly need an extra check just > for this. Users have explicitly enabled zstd-compression that they > needed for their kernel (meaning they at least had zstd), and if it > somehow dies with "zstd: command not found" I think it's > self-explanatory. >=20 > Hard for it to be missing even if it's not in @system too given portage > currently depends on it. Not to say it couldn't, or change. >=20 Very well, less patches, less waitin'. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-eV2/zVrvo+jT3iJ+sRgH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmWQQhgSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQO6MwH/R1kidBB4FwTWQub0UnTePU9Q3gHuzKX IGlJg+H76HzUisf6zUdpKYzAgQimpa9Nvv47cgzwoGnM7dg0c8uARMawjXIajQ0T X5nSf/njddPUqSTCXbFHXrXEiSCheeXudLbROfUNzGl53fJozOX00g3CUzQ3XBX2 wkpvDLeyf4U457nT+7cDsS97NfcEYJJskw94ma2sXn2CG4qJ13H+2vFLURJnCUuf PLVJL47FWHFNcK7y/L4HY8wsL4GQHKuDA06gyNAxiUb5npR9kx7t458Qh3Yz5jNf zvXD1VVlag2Pwx3ysWf/+LjIZZLQBsIxHtI8SbMb5HwtnA9h04r0RcU= =o29i -----END PGP SIGNATURE----- --=-eV2/zVrvo+jT3iJ+sRgH--