From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1ItZVS-0000bb-0l for garchives@archives.gentoo.org; Sun, 18 Nov 2007 02:03:30 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.2/8.14.0) with SMTP id lAI22bCc023406; Sun, 18 Nov 2007 02:02:37 GMT Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.174]) by robin.gentoo.org (8.14.2/8.14.0) with ESMTP id lAI1xRmN016178 for ; Sun, 18 Nov 2007 01:59:28 GMT Received: by ug-out-1314.google.com with SMTP id j3so809352ugf for ; Sat, 17 Nov 2007 17:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type; bh=MwF08Wv4mjtnrE2fWsbiKcidOHu0XRmYE24L88siTIU=; b=CbXAdyEnXpUNNq5EMoSofgPa2e+u/yrjGOh5BNZBvT+uQzaaBbzJ1h2Um8ZzAwDbYEEm8AO4O0TRFofegaXST8NLv4qVNVReE7/tcbZjvjWwJYUFug6kVSwQvYlTL8bNv2Usl6Hv2FCJ7jmgrR8CHSIfEJ/0QdRvkT7jMLpeODY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type; b=lfmRS+z35OWHVcaQesTRJsqxz2wlXcioBvKO+SoWrGCbmE4zdhnMCuDl5pCw+UDEVTQAWPuRfcpYVENW22tRmHTA0hzQIQL/OawtlKcn0zPUEgxQcpK8tUZdyAz4WWJn24u36A3IO84COWz/i5hLpsIg5rCBUweNgyiLj2Ygk68= Received: by 10.66.242.9 with SMTP id p9mr442514ugh.1195351167499; Sat, 17 Nov 2007 17:59:27 -0800 (PST) Received: from ?192.168.0.2? ( [88.66.254.110]) by mx.google.com with ESMTPS id b36sm5269979ika.2007.11.17.17.59.25 (version=SSLv3 cipher=RC4-MD5); Sat, 17 Nov 2007 17:59:26 -0800 (PST) Message-ID: <473F9C7B.4060204@googlemail.com> Date: Sun, 18 Nov 2007 02:59:23 +0100 From: Daniel Pielmeier User-Agent: Thunderbird 2.0.0.9 (X11/20071116) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Patch make_desktop_entry to produce entries that validate better References: <473F70F7.4030505@gentoo.org> <473F80D5.5060004@gentoo.org> In-Reply-To: <473F80D5.5060004@gentoo.org> Content-Type: multipart/mixed; boundary="------------010304090102060702000907" X-Archives-Salt: c89e4ca7-efb4-4d74-aa97-7e827477de32 X-Archives-Hash: 80386c4c0ba82df5aa4a9fd70ecd3319 This is a multi-part message in MIME format. --------------010304090102060702000907 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by robin.gentoo.org id lAI22bEI023406 Petteri R=C3=A4ty schrieb: > Petteri R=C3=A4ty kirjoitti: >> Any objections to the attached patch: >> >> betelgeuse@pena ~ $ desktop-file-validate >> /usr/share/applications/jedit-jedit.desktop >> /usr/share/applications/jedit-jedit.desktop: warning: key "Encoding" i= n >> group "Desktop Entry" is deprecated >> /usr/share/applications/jedit-jedit.desktop: warning: value "" for key >> "Path" in group "Desktop Entry" does not look like an absolute path >> >> Regards, >> Petteri >> >=20 > Hmm. Wrong patch attached. There are two other bugs (#197891, #181999) which are related to changes regarding the freedesktop specs. One for the Encoding key depreciation which you can see above too and one for the Icon key which should not specify a suffix if the value does not use the full path to the icon. These could be taken into consideration when desktop-file-utils-0.14 is stable on all archs. I have attached an updated patch. Regards, Daniel --------------010304090102060702000907 Content-Type: text/plain; name="make_desktop_entry.patch" Content-Disposition: inline; filename="make_desktop_entry.patch" Content-Transfer-Encoding: base64 LS0tIGV1dGlscy5lY2xhc3MJMjAwNy0xMS0xOCAwMjowNjo1MC4wMDAwMDAwMDAgKzAxMDAK KysrIGV1dGlscy5lY2xhc3MJMjAwNy0xMS0xOCAwMjozMjo0NC4wMDAwMDAwMDAgKzAxMDAK QEAgLTc0MSw3ICs3NDEsNyBAQAogCiAJbG9jYWwgZXhlYz0kezF9CiAJbG9jYWwgbmFtZT0k ezI6LSR7UE59fQotCWxvY2FsIGljb249JHszOi0ke1BOfS5wbmd9CisJbG9jYWwgaWNvbj0k ezM6LSR7UE59fQogCWxvY2FsIHR5cGU9JHs0fQogCWxvY2FsIHBhdGg9JHs1fQogCkBAIC04 NzUsMTggKzg3NSwxOCBAQAogCiAJY2F0IDw8LUVPRiA+ICIke2Rlc2t0b3B9IgogCVtEZXNr dG9wIEVudHJ5XQotCUVuY29kaW5nPVVURi04CiAJVmVyc2lvbj0xLjAKIAlOYW1lPSR7bmFt ZX0KIAlUeXBlPUFwcGxpY2F0aW9uCiAJQ29tbWVudD0ke0RFU0NSSVBUSU9OfQogCUV4ZWM9 JHtleGVjfQogCVRyeUV4ZWM9JHtleGVjJSUgKn0KLQlQYXRoPSR7cGF0aH0KIAlJY29uPSR7 aWNvbn0KIAlDYXRlZ29yaWVzPSR7dHlwZX07CiAJRU9GCiAKKwlbWyAke3BhdGh9IF1dICYm IGVjaG8gIlBhdGg9JHtwYXRofSIgPj4gIiR7ZGVza3RvcH0iCisKIAkoCiAJCSMgd3JhcCB0 aGUgZW52IGhlcmUgc28gdGhhdCB0aGUgJ2luc2ludG8nIGNhbGwKIAkJIyBkb2Vzbid0IGNv cnJ1cHQgdGhlIGVudiBvZiB0aGUgY2FsbGVyCkBAIC05MzgsNyArOTM4LDYgQEAKIAogCWNh dCA8PC1FT0YgPiAiJHtkZXNrdG9wfSIKIAlbRGVza3RvcCBFbnRyeV0KLQlFbmNvZGluZz1V VEYtOAogCU5hbWU9JHt0aXRsZX0KIAlDb21tZW50PVRoaXMgc2Vzc2lvbiBsb2dzIHlvdSBp bnRvICR7dGl0bGV9CiAJRXhlYz0ke2NvbW1hbmR9Cg== --------------010304090102060702000907-- -- gentoo-dev@gentoo.org mailing list