From: "Petteri Räty" <betelgeuse@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Patch make_desktop_entry to produce entries that validate better
Date: Sun, 18 Nov 2007 02:01:25 +0200 [thread overview]
Message-ID: <473F80D5.5060004@gentoo.org> (raw)
In-Reply-To: <473F70F7.4030505@gentoo.org>
[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]
Petteri Räty kirjoitti:
> Any objections to the attached patch:
>
> betelgeuse@pena ~ $ desktop-file-validate
> /usr/share/applications/jedit-jedit.desktop
> /usr/share/applications/jedit-jedit.desktop: warning: key "Encoding" in
> group "Desktop Entry" is deprecated
> /usr/share/applications/jedit-jedit.desktop: warning: value "" for key
> "Path" in group "Desktop Entry" does not look like an absolute path
>
> Regards,
> Petteri
>
Hmm. Wrong patch attached.
[-- Attachment #1.2: make_desktop_entry.patch --]
[-- Type: text/plain, Size: 596 bytes --]
Index: eutils.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.292
diff -u -r1.292 eutils.eclass
--- eutils.eclass 14 Oct 2007 21:55:35 -0000 1.292
+++ eutils.eclass 17 Nov 2007 22:53:28 -0000
@@ -882,11 +882,12 @@
Comment=${DESCRIPTION}
Exec=${exec}
TryExec=${exec%% *}
- Path=${path}
Icon=${icon}
Categories=${type};
EOF
+ [[ ${path} ]] && echo "Path=${path}" >> "${desktop}"
+
(
# wrap the env here so that the 'insinto' call
# doesn't corrupt the env of the caller
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
next prev parent reply other threads:[~2007-11-18 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 22:53 [gentoo-dev] Patch make_desktop_entry to produce entries that validate better Petteri Räty
2007-11-18 0:01 ` Petteri Räty [this message]
2007-11-18 1:59 ` Daniel Pielmeier
2007-11-20 22:32 ` Chris Gianelloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473F80D5.5060004@gentoo.org \
--to=betelgeuse@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox