From: Krzysiek Pawlik <nelchael@gentoo.org>
To: Gentoo Dev <gentoo-dev@lists.gentoo.org>
Subject: [gentoo-dev] repoman and checking for correct quoting
Date: Sat, 10 Nov 2007 11:51:37 +0100 [thread overview]
Message-ID: <47358D39.8050901@gentoo.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
Consider following part of scite-1.74.ebuild:
sed -i makefile \
-e 's#usr/local#usr#g' \
-e 's#/gnome/apps/Applications#/applications#' \
-e "s#^CXXFLAGS=#CXXFLAGS=${CXXFLAGS} #" \
-e "s#^\(CXXFLAGS=.*\)-Os#\1#" \
-e "s#^CC =\(.*\)#CC = $(tc-getCXX)#" \
-e 's#${D}##' \
-e 's#-g root#-g 0#' \
|| die "error patching makefile"
`repoman full' catches line "-e 's#${D}##' \":
app-editors/scite/scite-1.74.ebuild: Unquoted Variable on line: 41
It's purpose is to remove the ${D} from makefile, additionally ${D} is in single
quotes, so it will not be expanded - is it a bug in repoman check?
--
Krzysiek Pawlik <nelchael at gentoo.org> key id: 0xBC555551
desktop-misc, desktop-dock, x86, java, apache, ppc...
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
next reply other threads:[~2007-11-10 10:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 10:51 Krzysiek Pawlik [this message]
2007-11-10 17:10 ` [gentoo-dev] repoman and checking for correct quoting Zac Medico
2007-11-10 17:36 ` Bo Ørsted Andresen
2007-11-10 17:50 ` [gentoo-dev] to patch or sed was -> " William L. Thomson Jr.
2007-11-10 19:45 ` [gentoo-dev] " Ryan Hill
2007-11-10 22:17 ` William L. Thomson Jr.
2007-11-11 10:47 ` Steve Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47358D39.8050901@gentoo.org \
--to=nelchael@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox