public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Krzysiek Pawlik <nelchael@gentoo.org>
To: "Wulf C. Krueger" <philantrop@gentoo.org>,
	Gentoo Dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] RFC: cmake.eclass
Date: Sun, 04 Nov 2007 14:30:37 +0100	[thread overview]
Message-ID: <472DC97D.7000504@gentoo.org> (raw)
In-Reply-To: <200711041420.38049.philantrop@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Wulf C. Krueger wrote:
> KDE4 will make use of cmake-utils.eclass we wrote because

Why call it cmake-utils?

> - we need use_enable- and use_with-like functions for cmake (makes ebuilds 
> easier to read)

Could be done.

> - in-source and out-of-source build support

Got it too :)

> - we need LIB_SUFFIX support

Could be added easily.

> - our KDE4 eclasses rely on it.

Not in tree yet.

> You might want to take a look at it. It's in the tree. I don't really 
> think we need two implementations.

I think so too. I've got few suggestions:

 * in cmake-utils_src_make():
   emake ${@} - it would allow something like this:

    cmake-utils_src_make -j1

 * if you `cd' into build directory - *please* return to ${S} -> use pushd/popd.

Last thing: please reply to gentoo-dev too :)

-- 
Krzysiek Pawlik   <nelchael at gentoo.org>   key id: 0xBC555551
desktop-misc, desktop-dock, x86, java, apache, ppc...


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

  parent reply	other threads:[~2007-11-04 13:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-04 11:51 [gentoo-dev] RFC: cmake.eclass Krzysiek Pawlik
2007-11-04 12:12 ` Donnie Berkholz
2007-11-04 12:34   ` Krzysiek Pawlik
     [not found] ` <200711041420.38049.philantrop@gentoo.org>
2007-11-04 13:30   ` Krzysiek Pawlik [this message]
2007-11-04 14:09     ` Krzysiek Pawlik
2007-11-04 14:35       ` Wulf C. Krueger
2007-11-04 14:01 ` Marijn Schouten (hkBst)
2007-11-04 14:07   ` Krzysiek Pawlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472DC97D.7000504@gentoo.org \
    --to=nelchael@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=philantrop@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox