From: "Rémi Cardona" <remi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild
Date: Wed, 31 Oct 2007 19:38:38 +0100 [thread overview]
Message-ID: <4728CBAE.1090805@gentoo.org> (raw)
In-Reply-To: <4728C88C.1090406@gentoo.org>
Marijn Schouten (hkBst) wrote:
> Donnie Berkholz wrote:
>> If you moved the filter-ldflags() call up to pkg_setup(), you could drop
>> src_compile() altogether to clean up the ebuild a little.
>
> Wouldn't that make binary packages cry?
In theory, autotools scripts allow users to set env variables only
during the configure phase. Running 'CFLAGS="blah" make' should be
exactly the same as runing make on its own.
So I'd go as far as saying that puting the filter-ldflags() in
src_compile() would not work.
As for what python distutils scripts do exactly ...
Rémi
--
gentoo-dev@gentoo.org mailing list
next prev parent reply other threads:[~2007-10-31 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1InFeX-0000UI-Jz@stork.gentoo.org>
2007-10-31 17:58 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild Donnie Berkholz
2007-10-31 18:25 ` Marijn Schouten (hkBst)
2007-10-31 18:38 ` Rémi Cardona [this message]
2007-10-31 19:13 ` Donnie Berkholz
2007-11-01 6:22 ` Mike Frysinger
2007-11-02 6:22 ` Donnie Berkholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4728CBAE.1090805@gentoo.org \
--to=remi@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox