From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1InIH1-0000bu-Sc for garchives@archives.gentoo.org; Wed, 31 Oct 2007 18:26:40 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9VIPnKr000380; Wed, 31 Oct 2007 18:25:49 GMT Received: from castor.sshunet.nl (castor.sshunet.nl [145.97.192.41]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9VINjLo030349 for ; Wed, 31 Oct 2007 18:23:45 GMT Received: from localhost (localhost.localdomain [127.0.0.1]) by castor.sshunet.nl (Postfix) with ESMTP id B5ECB57C002 for ; Wed, 31 Oct 2007 19:23:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at castor.sshunet.nl Received: from castor.sshunet.nl ([127.0.0.1]) by localhost (castor.sshunet.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ogW0Buob+RrY for ; Wed, 31 Oct 2007 19:23:45 +0100 (CET) Received: from [145.97.223.26] (26pc223.sshunet.nl [145.97.223.26]) by castor.sshunet.nl (Postfix) with ESMTP for ; Wed, 31 Oct 2007 19:23:45 +0100 (CET) Message-ID: <4728C88C.1090406@gentoo.org> Date: Wed, 31 Oct 2007 19:25:16 +0100 From: "Marijn Schouten (hkBst)" User-Agent: Thunderbird 2.0.0.6 (X11/20070802) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild References: <20071031175801.GL30328@supernova> In-Reply-To: <20071031175801.GL30328@supernova> X-Enigmail-Version: 0.95.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 57e160dc-86ff-4282-bade-18be02302957 X-Archives-Hash: af555f009dfb3b27d7920e71bee1e140 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Donnie Berkholz wrote: > On 15:38 Wed 31 Oct , Raul Porcel (armin76) wrote: >> 1.1 net-p2p/deluge/deluge-0.5.6.2.ebuild >> >> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&view=markup >> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&content-type=text/plain > >> pkg_setup() { >> if has_version "> ! built_with_use "dev-libs/boost" threads; then >> eerror "dev-libs/boost has to be built with threads USE-flag." >> die "Missing threads USE-flag for dev-libs/boost" >> fi >> } >> >> src_compile() { >> filter-ldflags -Wl,--as-needed >> >> distutils_src_compile >> } > > If you moved the filter-ldflags() call up to pkg_setup(), you could drop > src_compile() altogether to clean up the ebuild a little. Wouldn't that make binary packages cry? Marijn - -- Marijn Schouten (hkBst), Gentoo Lisp project , #gentoo-lisp on FreeNode -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHKMiMp/VmCx0OL2wRAuCGAJ9WdFT5k7bGxZCEJOT0hiwjWZafpgCfYh5F ONjgCrQ0Y8kf7HI/97YU4AU= =tPfT -----END PGP SIGNATURE----- -- gentoo-dev@gentoo.org mailing list