public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Resolving HAL vs. pciutils/usbutils
Date: Wed, 31 Oct 2007 16:26:55 +0000	[thread overview]
Message-ID: <4728ACCF.7000702@gentoo.org> (raw)
In-Reply-To: <4728A1D2.4020801@gentoo.org>

Doug Goldstein wrote:
> When HAL evaluated the usage of  libpci the following issues were
> identified:
>  1) increased memory usage, to the point that HAL was not usable on the
> OLPC project

I was only ever aware of concerns that memory usage might be high, but 
wasn't aware it caused specific problems.

I went through the first 3 pages of google results for
	"pciutils inurl:hal site:lists.freedesktop.org"
	"libpci inurl:hal site:lists.freedesktop.org"
and didn't see anything. Maybe it was discussed elsewhere.

Anyway, if this did happen once, it doesn't seem to happen any more, see 
below.

>  2) ABI breakage between patch revisions (i.e. x.y.z and x.y.z+1 were
> not ABI compatible)

This doesn't matter when you statically link against the library, as 
long as the API doesn't change. The API that is used in Mike's patch 
does not seem to have changed for a long time. (Nevertheless, see my 
notes under the following item -- this will be solved when the next one 
is solved.)

>  3) no shared library

This is a fair point, but I thought it was never raised as an objection, 
I didn't think it was actually a blocker for acceptance. Especially 
given that parts of HAL already statically link against libpci.

I just looked over the threads again and I now see this:
http://lists.freedesktop.org/archives/hal/2007-June/008836.html

I apologise, I must have missed that before.
OK, so having a dynamic libpci is an outstanding requirement for the 
patch. I will follow up with pciutils upstream about the current state 
of that.

>  4) the library calls exit() when it encounters an error in parsing it's
> own pci.ids file which would kill the whole app using it.
> 
> There might have been more. I don't remember. Refer to ML discussions
> and refer to IRC logs with me.

I looked over them, I don't see any others.

> Now Mike (vapier) rectified #4 several pciutils releases ago by
> providing a callback function that we could define which would override
> the default exit() behavior. I still think it's sub-par to have an
> utility library call exit() by default but whatever.

Yeah.

> You were told by me and the HAL ML that once #2 and #3 are rectified and
> if you could provide some basic memory usage information along with your
> patch (i.e. show #1 isn't true anymore) that we would happily accept
> your patch.

> You addressed #1 on the mailing list with a simple statement, which I
> will paraphrase. "It doesn't use more memory on my machine". To which
> Danny K asked if you could provide some basic data behind that and you
> never did.

I did:
http://lists.freedesktop.org/archives/hal/2007-June/008852.html
http://lists.freedesktop.org/archives/hal/2007-June/008861.html


Anyway, apologies for the oversight on the shared library thing -- it 
appears it wasn't total silent rejection after all. I'll let you know 
where that leads.

Thanks,
Daniel
-- 
gentoo-dev@gentoo.org mailing list



  parent reply	other threads:[~2007-10-31 16:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31  1:56 [gentoo-dev] Resolving HAL vs. pciutils/usbutils Robin H. Johnson
2007-10-31 10:46 ` Daniel Drake
2007-10-31 11:04   ` [gentoo-dev] " Guilherme Amadio
2007-10-31 11:31     ` Jan Kundrát
2007-10-31 13:30   ` Ryan Hill
2007-10-31 15:09   ` [gentoo-dev] " Wulf C. Krueger
2007-10-31 14:56     ` Daniel Drake
2007-10-31 15:40   ` Doug Goldstein
2007-10-31 16:12     ` Roy Marples
2007-10-31 17:07       ` Rémi Cardona
2007-10-31 16:26     ` Daniel Drake [this message]
2007-10-31 16:41       ` Jan Kundrát

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4728ACCF.7000702@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox