public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Richard Freeman <rich@thefreemanclan.net>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Opinions Wanted - Arrays again :)
Date: Fri, 26 Oct 2007 06:16:50 -0400	[thread overview]
Message-ID: <4721BE92.4070200@thefreemanclan.net> (raw)
In-Reply-To: <1193380105.2913.1.camel@uberpc.marples.name>

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Roy Marples wrote:
>>> 0_config_eth0="1.2.3.4 netmask 5.6.7.8;"
>>> 1_config_eth0="\*"
>>> 2_config_eth0="'host.name' netmask 1.2.3.4"
>>> 3_config_eth0="-I 'option; $FOO with spaces'"
>> I was hoping for some sort of meaningfully named separate variables, not 
>> an even messier fake array.
> 
> I'm all ears for any other suggestions :)
> 

If there is some problem with this suggestion feel free to shoot it full
of holes, but how about something like:

address_eth0="1.2.3.4"
netmask_eth0="255.255.255.0"
broadcast_eth0="1.2.3.255"
gateway_eth0="1.2.3.1"
network_eth0="1.2.3.0"
hostname_eth0="mypc"
options_eth0="bells and whistles"

Without digging through the original source I'm not sure what everything
else in that array is, but I think you get the picture.  Instead of
sticking all these parameters into a big array why not break them down
into what they actually are used for?  This should also make the code
that actually reads back these variables a lot more readable - instead
of wondering what the 5th field in the array is you would see something
meaningful like "netmask".

Again, if I'm missing some reason why this wouldn't work feel free to
point it out.  :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHIb6OG4/rWKZmVWkRAhvzAJ0eoNK8I73+HU3tVRnJzFMJwYKSqQCgqzoW
j71E+DxgfrGTRSwKWgCmW40=
=qitq
-----END PGP SIGNATURE-----

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 4101 bytes --]

  reply	other threads:[~2007-10-26 10:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 15:40 [gentoo-dev] Opinions Wanted - Arrays again :) Roy Marples
2007-10-25 16:02 ` Marijn Schouten (hkBst)
2007-10-25 16:18   ` Roy Marples
2007-10-25 16:37     ` Ioannis Aslanidis
2007-10-26 11:30     ` Roy Marples
2007-10-25 17:18 ` Josh Saddler
2007-10-25 21:31 ` Donnie Berkholz
2007-10-25 21:49   ` Roy Marples
2007-10-25 22:56     ` Donnie Berkholz
2007-10-26  6:28       ` Roy Marples
2007-10-26 10:16         ` Richard Freeman [this message]
2007-10-26 10:42           ` Roy Marples
2007-10-26 16:36             ` [gentoo-dev] " Duncan
2007-10-26 17:03               ` Roy Marples
2007-10-26 18:57                 ` Duncan
2007-10-26 21:17                   ` Roy Marples
2007-10-27  3:02                     ` Richard Freeman
2007-10-28  6:46                 ` [gentoo-dev] " Steve Long
2007-10-29  7:35                   ` Natanael Copa
2007-10-30  3:55                     ` [gentoo-dev] " Steve Long
2007-10-26  6:13 ` [gentoo-dev] " Alec Warner
2007-10-26  6:32   ` Roy Marples
2007-10-29  9:50 ` Roy Marples
2007-10-30  3:58   ` [gentoo-dev] " Steve Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4721BE92.4070200@thefreemanclan.net \
    --to=rich@thefreemanclan.net \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox