public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Josh Saddler <nightmorph@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Opinions Wanted - Arrays again :)
Date: Thu, 25 Oct 2007 10:18:25 -0700	[thread overview]
Message-ID: <4720CFE1.1060406@gentoo.org> (raw)
In-Reply-To: <1193326831.4245.16.camel@uberlaptop.marples.name>

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

Roy Marples wrote:
> Hello List
> 
> It's your favourite posix shell lover here, asking for your honest
> opinions.
> 
> array="1.2.3.4 netmask 5.6.7.8;
> \*
> 'host.name' netmask 1.2.3.4
> -I 'option; $FOO with spaces'
> "
> 
> array=("1.2.3.4 netmask 5.6.7.8;"
> "\*"
> "'host.name' netmask 1.2.3.4"
> "-I 'option; $FOO with spaces'"
> )
> 
> array="'1.2.3.4 netmask 5.6.7.8;' \
> '\*' \
> \"'host.name' netmask 1.2.3.4\" \
> \"-I 'option; $FOO with spaces'\"
> "
> 
> The first and last are of course posix constructs whilst the middle is
> bash.
> 
> The bash one is purely there for reference, and of course you can still
> use it if /bin/sh is bash. The last one is what baselayout-2 currently
> uses and I'm wondering if we should switch to the first one before we
> come out of package.mask.
> 
> I'm asking which you think are the most readable of the first and last
> ones and if you see any issues with either.

The first is much more readable than the last, but only slightly more
readable than the middle one. I'm not a sh/bash guru the way many of the
developers are, and I can tell you right up front that I'd be more
comfortable configuring options if they looked more like the first
example, and I'd guess many users would feel the same way. The fewer " '
; \ characters there are to keep track of, the better.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2007-10-25 17:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 15:40 [gentoo-dev] Opinions Wanted - Arrays again :) Roy Marples
2007-10-25 16:02 ` Marijn Schouten (hkBst)
2007-10-25 16:18   ` Roy Marples
2007-10-25 16:37     ` Ioannis Aslanidis
2007-10-26 11:30     ` Roy Marples
2007-10-25 17:18 ` Josh Saddler [this message]
2007-10-25 21:31 ` Donnie Berkholz
2007-10-25 21:49   ` Roy Marples
2007-10-25 22:56     ` Donnie Berkholz
2007-10-26  6:28       ` Roy Marples
2007-10-26 10:16         ` Richard Freeman
2007-10-26 10:42           ` Roy Marples
2007-10-26 16:36             ` [gentoo-dev] " Duncan
2007-10-26 17:03               ` Roy Marples
2007-10-26 18:57                 ` Duncan
2007-10-26 21:17                   ` Roy Marples
2007-10-27  3:02                     ` Richard Freeman
2007-10-28  6:46                 ` [gentoo-dev] " Steve Long
2007-10-29  7:35                   ` Natanael Copa
2007-10-30  3:55                     ` [gentoo-dev] " Steve Long
2007-10-26  6:13 ` [gentoo-dev] " Alec Warner
2007-10-26  6:32   ` Roy Marples
2007-10-29  9:50 ` Roy Marples
2007-10-30  3:58   ` [gentoo-dev] " Steve Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4720CFE1.1060406@gentoo.org \
    --to=nightmorph@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox