From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IhRHI-00074V-F4 for garchives@archives.gentoo.org; Mon, 15 Oct 2007 14:50:44 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9FEdgCM007833; Mon, 15 Oct 2007 14:39:42 GMT Received: from nameserver1.mcve.com (nameserver1.mcve.com [216.155.111.1]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9FEb6mc004341 for ; Mon, 15 Oct 2007 14:37:07 GMT Received: from [192.168.1.55] (shop.monetra.com [216.155.111.10]) by nameserver1.mcve.com (Postfix) with ESMTP id B2E911148001 for ; Mon, 15 Oct 2007 10:37:05 -0400 (EDT) Message-ID: <47137B11.1070003@gentoo.org> Date: Mon, 15 Oct 2007 10:37:05 -0400 From: Doug Goldstein User-Agent: Thunderbird 2.0.0.6 (X11/20070802) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/mythtv: ChangeLog mythtv-0.20.2_p14668.ebuild mythtv-0.21_pre14666.ebuild mythtv-0.21_pre14480-r1.ebuild References: <20071013004453.GM23990@supernova> <4711974B.6010505@gentoo.org> <20071014045010.GS23990@supernova> <47137651.8040503@gentoo.org> <47137849.7030608@utas.edu.au> In-Reply-To: <47137849.7030608@utas.edu.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 67fe2263-8abb-41e9-91f6-1a69dd8e9696 X-Archives-Hash: 202fec89ef6aa056f7ce40817e15701e Jonathan Adamczewski wrote: > Doug Goldstein wrote: > >> That's what this commits review list feels like. >> >> > > > Nearly every suggestion (from Donnie and others) has been over some > issue that relates directly to either correctness or maintainability. > It doesn't matter if you can "rattle off capabilities to a millimeter" - > if they're not documented somewhere (like, say, in the comments of the > ebuild) then the maintainer that comes after you gets to go and break it > all over again. > > > jonathan. > Correctness? Fine. Go ahead. Stick $(use_enable xvmc) into the ebuild. Do it. I dare you. Then try to compile. Guess what? When it blows up... that's called INcorrect. The opposite of the right thing. The maintainer who comes after me would be someone with a experience with the package. Some bumkin isn't going to come to maintain package XYZ unless they know or use the package, and guess what? That means experience. -- gentoo-dev@gentoo.org mailing list