public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Doug Goldstein <cardoe@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in  media-tv/mythtv: ChangeLog mythtv-0.20.2_p14668.ebuild  mythtv-0.21_pre14666.ebuild  mythtv-0.21_pre14480-r1.ebuild
Date: Mon, 15 Oct 2007 10:37:05 -0400	[thread overview]
Message-ID: <47137B11.1070003@gentoo.org> (raw)
In-Reply-To: <47137849.7030608@utas.edu.au>

Jonathan Adamczewski wrote:
> Doug Goldstein wrote:
>   
>> That's what this commits review list feels like.
>>   
>>     
>
>
> Nearly every suggestion (from Donnie and others) has been over some
> issue that relates directly to either correctness or maintainability. 
> It doesn't matter if you can "rattle off capabilities to a millimeter" -
> if they're not documented somewhere (like, say, in the comments of the
> ebuild) then the maintainer that comes after you gets to go and break it
> all over again.
>
>
> jonathan.
>   
Correctness? Fine. Go ahead. Stick $(use_enable xvmc) into the ebuild.
Do it. I dare you. Then try to compile.

Guess what? When it blows up... that's called INcorrect. The opposite of
the right thing.

The maintainer who comes after me would be someone with a experience
with the package. Some bumkin isn't going to come to maintain package
XYZ unless they know or use the package, and guess what? That means
experience.


-- 
gentoo-dev@gentoo.org mailing list



  reply	other threads:[~2007-10-15 14:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1IgPfK-0005R4-Tw@stork.gentoo.org>
2007-10-13  0:44 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/mythtv: ChangeLog mythtv-0.20.2_p14668.ebuild mythtv-0.21_pre14666.ebuild mythtv-0.21_pre14480-r1.ebuild Donnie Berkholz
2007-10-14  4:12   ` Doug Goldstein
2007-10-14  4:50     ` Donnie Berkholz
2007-10-14 12:02       ` [gentoo-dev] " Steve Long
2007-10-15 14:16       ` [gentoo-dev] " Doug Goldstein
2007-10-15 14:25         ` Jonathan Adamczewski
2007-10-15 14:37           ` Doug Goldstein [this message]
2007-10-15 18:31             ` Christian Faulhammer
2007-10-15 21:00               ` Doug Goldstein
2007-10-16 10:09                 ` Marijn Schouten (hkBst)
2007-10-15 19:14             ` Alec Warner
2007-10-15 20:57               ` Doug Goldstein
2007-10-15 22:09                 ` Donnie Berkholz
2007-10-16  1:17                 ` Ryan Hill
2007-10-16 23:04               ` Drake Wyrm
2007-10-15 20:57         ` [gentoo-dev] " Steve Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47137B11.1070003@gentoo.org \
    --to=cardoe@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox