From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IhR99-0006jq-6w for garchives@archives.gentoo.org; Mon, 15 Oct 2007 14:42:19 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9FEUmpM027824; Mon, 15 Oct 2007 14:30:48 GMT Received: from ipmail03.adl2.internode.on.net (ipmail03.adl2.internode.on.net [203.16.214.135]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9FESeAN025183 for ; Mon, 15 Oct 2007 14:28:42 GMT X-IronPort-AV: E=Sophos;i="4.21,277,1188743400"; d="scan'208";a="167433374" Received: from ppp121-44-209-134.lns1.hba1.internode.on.net (HELO [192.168.1.1]) ([121.44.209.134]) by ipmail03.adl2.internode.on.net with ESMTP; 15 Oct 2007 23:56:29 +0930 Message-ID: <47137849.7030608@utas.edu.au> Date: Tue, 16 Oct 2007 01:25:13 +1100 From: Jonathan Adamczewski User-Agent: Thunderbird 2.0.0.6 (X11/20070803) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/mythtv: ChangeLog mythtv-0.20.2_p14668.ebuild mythtv-0.21_pre14666.ebuild mythtv-0.21_pre14480-r1.ebuild References: <20071013004453.GM23990@supernova> <4711974B.6010505@gentoo.org> <20071014045010.GS23990@supernova> <47137651.8040503@gentoo.org> In-Reply-To: <47137651.8040503@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: bbababc4-e5f3-49ba-a796-0d3849b4760b X-Archives-Hash: 27a8d063a630830fcda118ffba3f3807 Doug Goldstein wrote: > > That's what this commits review list feels like. > Nearly every suggestion (from Donnie and others) has been over some issue that relates directly to either correctness or maintainability. It doesn't matter if you can "rattle off capabilities to a millimeter" - if they're not documented somewhere (like, say, in the comments of the ebuild) then the maintainer that comes after you gets to go and break it all over again. jonathan. -- gentoo-dev@gentoo.org mailing list