[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygtksourceview: metadata.xml pygtksourceview-2.0.0.ebuild Manifest ChangeLog

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygtksourceview: metadata.xml pygtksourceview-2.0.0.ebuild Manifest ChangeLog

[Donnie Berkholz]

On 21:22 Wed 10 Oct     , Remi Cardona (remi) wrote:
> 1.1                  dev-python/pygtksourceview/pygtksourceview-2.0.0.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-python/pygtksourceview/pygtksourceview-2.0.0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-python/pygtksourceview/pygtksourceview-2.0.0.ebuild?rev=1.1&content-type=text/plain

> pkg_postinst() {
> 	python_version
> 	python_mod_optimize /usr/$(get_libdir)/python${PYVER}/site-packages/
> }
> 
> pkg_postrm() {
> 	python_version
> 	python_mod_optimize /usr/$(get_libdir)/python${PYVER}/site-packages/
> }

I think the python_mod_ functions take care of running python_version() 
... also have you noticed that you're optimizing in postrm instead of 
cleaning up?

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygtksourceview: metadata.xml pygtksourceview-2.0.0.ebuild Manifest ChangeLog

[Rémi Cardona]

Donnie Berkholz wrote:

> I think the python_mod_ functions take care of running python_version() 
> ... also have you noticed that you're optimizing in postrm instead of 
> cleaning up?

I just copied the ebuild from our overlay to portage. I think this
ebuild is quite similar to other gnome/python packages. Since I've never
really made anything related to python, I'll have to take your word for
it :)

Thanks for your review, I'll open a bug so that we can really clean up
our gnome/python ebuilds.

Rémi
-- 
gentoo-dev@gentoo.org mailing list