From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IcGob-0001PQ-24 for garchives@archives.gentoo.org; Mon, 01 Oct 2007 08:39:45 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l918TDcZ013351; Mon, 1 Oct 2007 08:29:13 GMT Received: from mail.ineton.ro (mail.ineton.ro [217.156.27.7]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l918RCQN011088 for ; Mon, 1 Oct 2007 08:27:12 GMT Received: (qmail 16243 invoked by uid 210); 1 Oct 2007 08:27:12 -0000 Received: from 85.186.255.216 (mrness@85.186.255.216) by hera (envelope-from , uid 201) with qmail-scanner-2.01st (clamdscan: 0.91.2/4442. spamassassin: 3.2.1. perlscan: 2.01st. Clear:RC:1(85.186.255.216):. Processed in 0.085918 secs); 01 Oct 2007 08:27:12 -0000 Received: from mail.technosoft.ro (HELO ?192.168.19.2?) (mrness@85.186.255.216) by mail.ineton.ro with ESMTPA; 1 Oct 2007 08:27:12 -0000 Message-ID: <4700AF54.2070107@gentoo.org> Date: Mon, 01 Oct 2007 11:27:00 +0300 From: =?UTF-8?B?QWxpbiBOxINzdGFj?= Organization: Gentoo Foundation User-Agent: Thunderbird 2.0.0.6 (X11/20070807) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in mail-filter/dspam: ChangeLog dspam-3.8.0-r7.ebuild References: <20070930205942.GI28813@supernova> <47008C86.5090208@gentoo.org> <20071001062639.GT28813@supernova> <47009DBA.3010507@gentoo.org> <20071001072249.GU28813@supernova> <4700A53A.3050503@gentoo.org> <20071001080423.GV28813@supernova> In-Reply-To: <20071001080423.GV28813@supernova> X-Enigmail-Version: 0.95.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFB11E68B8C34A649E5B590B2" X-Archives-Salt: 2e4564d3-3588-440b-a26a-4d028a471205 X-Archives-Hash: c537ecec33d2cef7e68fc3a0c2e28457 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFB11E68B8C34A649E5B590B2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Donnie Berkholz wrote: > On 10:43 Mon 01 Oct , Alin N=C4=83stac wrote: > =20 >> Donnie Berkholz wrote: >> =20 >>> It's better to do something smart than to force interactivity. In thi= s=20 >>> case, you as the maintainer would decide whether this USE combo meant= =20 >>> the user wanted virtual-users (if so, forcibly enable one of mysql or= =20 >>> postgres), or whether the user definitely did not want to pull in a=20 >>> database (if so, force off virtual-users). >>> =20 >>> =20 >> I cannot force mysql or postgres dependency just because user enabled >> virtual-users flag. >> IMO this case would definitely qualify for a pkg_setup die because >> virtual-users is a local useflag. By selecting virtual-users without >> enabling mysql or postgres storage backend, the user proved to be >> clueless and ebuild should provide the much needed clue. >> =20 > > One way to proceed is to not have both mysql and postgres as USE flags.= =20 > Have one as a flag, and have negation of that flag mean to use the=20 > other. Does that make sense for this package, or can they both=20 > reasonably be used at the same time? > > =20 sqlite, mysql and postgres useflags controls the storage backend drivers installed by this package. dspam can be installed with multiple storage drivers, but only one can be active and it is selected through its configuration file. > I strongly discourage dying here; do something smart and log a warning = > to the user about it. > =20 okay, how about this code: if use mysql || use postgres; then myconf=3D"${myconf} $(use_enable virtual-users)" else myconf=3D"${myconf} --disable-virtual-users" use virtual-users && ewarn "virtual-users support has been disabled because none of the compatible storage drivers who support that are enabled" fi --------------enigFB11E68B8C34A649E5B590B2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHAK9bozkEeOnWD00RAktmAJ9MhY7618Kgtr/oXEVypRQNY9y5EwCgkORi Zwt0F8HyWY0m79eKvcEdKgw= =E/TG -----END PGP SIGNATURE----- --------------enigFB11E68B8C34A649E5B590B2-- -- gentoo-dev@gentoo.org mailing list