From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3767C138334 for ; Fri, 2 Nov 2018 00:43:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C4E95E082D; Fri, 2 Nov 2018 00:43:38 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 76D55E0824 for ; Fri, 2 Nov 2018 00:43:38 +0000 (UTC) Received: from [192.168.1.143] (c-98-218-46-55.hsd1.md.comcast.net [98.218.46.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mjo) by smtp.gentoo.org (Postfix) with ESMTPSA id 64AF9335C36 for ; Fri, 2 Nov 2018 00:43:35 +0000 (UTC) Subject: Re: [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7 To: gentoo-dev@lists.gentoo.org References: <20181028013841.7bd52f2b363d0b11fbe97dd1@gentoo.org> <1540751368.7710.0.camel@gentoo.org> <20181029035705.59f926ed6e7e604baa84de0c@gentoo.org> <1540883938.1250.6.camel@gentoo.org> <20181102012744.475046f4a4cf9aadf5f17c67@gentoo.org> From: Michael Orlitzky Message-ID: <4628d13d-7239-fb6f-c5b6-455d72449c7a@gentoo.org> Date: Thu, 1 Nov 2018 20:47:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20181102012744.475046f4a4cf9aadf5f17c67@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Archives-Salt: f94182ea-51f7-4a63-b75d-29992ea4580c X-Archives-Hash: 421a062a70ae5cc7f4bcf65bf09bc7ba On 11/01/2018 06:27 PM, Andrew Savchenko wrote: > > This eclass is small, so no harm here. But for larger eclasses > (hello java-*.eclass) this will hinder updates considerably. I > prefer to fix something rather than to fix nothing while > frustrating in attempt to fix everything at once. > > Also this make git history review harder as fixes for independent > issues will be mixed together. > > So I kindly ask you for future updates (from everyone, not just > me) focus on review of the proposed changes instead of reviewing > full code. Thank you for understanding. > You don't have to fix everything at once. A thorough code review is incredibly valuable we shouldn't discourage anyone from doing them. On the other hand, if you decide to fix only some of the issues, that's your prerogative. I would however suggest that afterwards, you open a bug for the remaining improvements so that the valuable time of the reviewer is not wasted.