From: Michael Orlitzky <mjo@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7
Date: Thu, 1 Nov 2018 20:47:54 -0400 [thread overview]
Message-ID: <4628d13d-7239-fb6f-c5b6-455d72449c7a@gentoo.org> (raw)
In-Reply-To: <20181102012744.475046f4a4cf9aadf5f17c67@gentoo.org>
On 11/01/2018 06:27 PM, Andrew Savchenko wrote:
>
> This eclass is small, so no harm here. But for larger eclasses
> (hello java-*.eclass) this will hinder updates considerably. I
> prefer to fix something rather than to fix nothing while
> frustrating in attempt to fix everything at once.
>
> Also this make git history review harder as fixes for independent
> issues will be mixed together.
>
> So I kindly ask you for future updates (from everyone, not just
> me) focus on review of the proposed changes instead of reviewing
> full code. Thank you for understanding.
>
You don't have to fix everything at once. A thorough code review is
incredibly valuable we shouldn't discourage anyone from doing them.
On the other hand, if you decide to fix only some of the issues, that's
your prerogative. I would however suggest that afterwards, you open a
bug for the remaining improvements so that the valuable time of the
reviewer is not wasted.
next prev parent reply other threads:[~2018-11-02 0:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 22:38 [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7 Andrew Savchenko
2018-10-28 18:29 ` Michał Górny
2018-10-29 0:57 ` Andrew Savchenko
2018-10-30 7:18 ` Michał Górny
2018-11-01 22:27 ` Andrew Savchenko
2018-11-02 0:47 ` Michael Orlitzky [this message]
2018-11-02 14:20 ` Michał Górny
2018-11-05 15:37 ` Andrew Savchenko
2018-10-29 22:52 ` Andreas K. Huettel
2018-11-01 22:26 ` Andrew Savchenko
2018-11-01 22:25 ` [gentoo-dev] [PATCH v2] " Andrew Savchenko
2018-11-02 10:27 ` Ulrich Mueller
2018-11-05 14:30 ` Andrew Savchenko
2018-11-05 15:37 ` [gentoo-dev] [PATCH v3 2/2] " Andrew Savchenko
2018-11-17 11:38 ` Andrew Savchenko
2018-11-05 15:38 ` [gentoo-dev] [PATCH v3 1/2] " Andrew Savchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4628d13d-7239-fb6f-c5b6-455d72449c7a@gentoo.org \
--to=mjo@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox