[gentoo-dev] [RFC] update to the gnome2.eclass

[gentoo-dev] [RFC] update to the gnome2.eclass

[Rémi Cardona]

Hi all,

A few months ago, Mike (pioto) proposed a patch for the gnome2.eclass so 
that it stops reading from /var/db/* stuff. As of today, the current 
eclass has not yet been patched.

The bug is here : https://bugs.gentoo.org/show_bug.cgi?id=155993

The current issue is with the gtk icon cache updater, which is used by 
all gnome and xfce related apps, but by many others too (1101 individual 
ebuilds). It should be called only when there are icon updates because 
of performance issues.

The current eclass reads VDB CONTENTS to see if any icons are about to 
be added or removed. The real solution would be to export an environment 
variable but that doesn't work in portage as Zac pointed out (bugs 56407 
and 56408).

Right now, the reworked patch saves a file in 
/usr/share/gnome2-eclass/${PF}.icons

Since committing this will affect everybody including stable users, I 
would like ebuild/eclass gurus to review this small patch and tell me if 
there's anything wrong with it.

One issue right now is that I use "mkdir -p" which is probably wrong. I 
did not yet try using dodir instead, if that's the proper solution.

Thanks for any advice.

Rémi
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] [RFC] update to the gnome2.eclass

[Donnie Berkholz]

Rémi Cardona wrote:
> Right now, the reworked patch saves a file in 
> /usr/share/gnome2-eclass/${PF}.icons
> 
> Since committing this will affect everybody including stable users, I 
> would like ebuild/eclass gurus to review this small patch and tell me if 
> there's anything wrong with it.

Why is this going into /usr ? Seems like a temp file to me ... at best, 
/var/cache. Also, is there supposed to be some point where this file 
gets deleted, so every subsequent merge doesn't rerun the icon-cache 
thing even if it's unnecessary?

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] [RFC] update to the gnome2.eclass

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Sunday 15 April 2007, Donnie Berkholz wrote:
> Rémi Cardona wrote:
> > Right now, the reworked patch saves a file in
> > /usr/share/gnome2-eclass/${PF}.icons
> >
> > Since committing this will affect everybody including stable users, I
> > would like ebuild/eclass gurus to review this small patch and tell me if
> > there's anything wrong with it.
>
> Why is this going into /usr ? Seems like a temp file to me ... at best,
> /var/cache.

ebuilds shouldnt really install anything into /var/cache/ as you should be 
able to pretty much `rm -rf /var/cache/*` and have things work

> Also, is there supposed to be some point where this file 
> gets deleted, so every subsequent merge doesn't rerun the icon-cache
> thing even if it's unnecessary?

i guess that's the trick ... if the file is only used to rebuild the 
icon-cache after merging the package to $ROOT, then i feel like the file 
should be punted after that (and if anything, src_install would create the 
list in $D, the pkg_preinst would prep it for use and move it from $D to $T, 
and the pkg_postinst would utilize the list in $T) ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [gentoo-dev] [RFC] update to the gnome2.eclass

[Rémi Cardona]

Mike Frysinger wrote:
> i guess that's the trick ... if the file is only used to rebuild the 
> icon-cache after merging the package to $ROOT, then i feel like the file 
> should be punted after that (and if anything, src_install would create the 
> list in $D, the pkg_preinst would prep it for use and move it from $D to $T, 
> and the pkg_postinst would utilize the list in $T) ...

The cache updates needs to happen when merging *and* unmerging a
package. That's why it's in $D.

Cheers,

Rémi
--
gentoo-dev@gentoo.org mailing list