From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from <gentoo-dev+bounces-19767-garchives=archives.gentoo.org@gentoo.org>) id 1H3ki2-0004fP-7n for garchives@archives.gentoo.org; Mon, 08 Jan 2007 02:58:02 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.8) with SMTP id l082vBif023492; Mon, 8 Jan 2007 02:57:11 GMT Received: from spunkymail-a18.dreamhost.com (sd-green-bigip-81.dreamhost.com [208.97.132.81]) by robin.gentoo.org (8.13.8/8.13.8) with ESMTP id l082tApS008158 for <gentoo-dev@lists.gentoo.org>; Mon, 8 Jan 2007 02:55:11 GMT Received: from [192.168.0.103] (c-68-43-193-90.hsd1.mi.comcast.net [68.43.193.90]) by spunkymail-a18.dreamhost.com (Postfix) with ESMTP id 057125B52B for <gentoo-dev@lists.gentoo.org>; Sun, 7 Jan 2007 18:55:09 -0800 (PST) Message-ID: <45A1B2CD.1060204@gentoo.org> Date: Sun, 07 Jan 2007 21:56:13 -0500 From: Alec Warner <antarus@gentoo.org> Organization: Gentoo Linux User-Agent: Thunderbird 1.5.0.8 (X11/20061225) Precedence: bulk List-Post: <mailto:gentoo-dev@lists.gentoo.org> List-Help: <mailto:gentoo-dev+help@gentoo.org> List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org> List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org> List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org> X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Somewhat OT - Making a suggestion for games-emulation/tuxnes References: <1168221602.25773.35.camel@camille.espersunited.com> In-Reply-To: <1168221602.25773.35.camel@camille.espersunited.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 755895ec-4cd6-4dba-966c-9242a73a1dc1 X-Archives-Hash: 9e9fb3b56d32fb8d6483389eb476fdac Michael Sullivan wrote: > > Anyway, for people like me who have the X flag enabled and might > accidentally hit the escape key and lose their progress in the game, I > downloaded the source code of tuxnes-0.75 and commented out all the code > segments responsible for that ESC/"quit tuxnes" behaviour and I have > created a patch for each of the files affected (there are three.) What > I want to know is, should I submit the three patches in a bug report? I > don't have a modified ebuild ready that says, "if the X USE flag is > enabled, apply the patches" - I don't really know how to safely > write/edit ebuilds yet. Do I even submit them to Gentoo's bugzilla, or > should I paddle upstream with them? What should I do? > In general for something like this, there are a few things to consider. Is it a Gentoo Specific problem? If yes then it's usually our bug. Is it a feature request or a bug? Sometimes this is a hard distinction to make. In this case I'd say feature (but it's debatable) Either way, is there a patch for it available. Some maintainers will take patches because they are useful. Usually it is a good idea to submit these patches upstream (gentoo devs hate having patches only in Gentoo, we don't want to maintain them, so bonus for us if upstream adds them in the next version = less work for us later). Some devs will wait until upstream accepts the patch before putting it in the tree (I usually do this). So for a non-gentoo problem upstream is usually the first place to go; as often as not you can get a yay or nay on a patch from upstream in a sane amount of time. If they say yes to it you can then file a bug in GEntoo and reference your upstream request, asking that we patch the package until upstream merges it and releases it. -- gentoo-dev@gentoo.org mailing list