From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 80AD715800F for ; Sat, 7 Jan 2023 04:29:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 10D82E07E0; Sat, 7 Jan 2023 04:29:33 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BBDE0E07D4 for ; Sat, 7 Jan 2023 04:29:32 +0000 (UTC) Content-Type: multipart/signed; boundary="Apple-Mail=_E3BBCF7F-1E36-4F26-9598-498A59879606"; protocol="application/pgp-signature"; micalg=pgp-sha512 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [gentoo-dev] [PATCH] gradle.eclass: add new eclass From: Sam James In-Reply-To: <20230106172051.274199-2-flow@gentoo.org> Date: Sat, 7 Jan 2023 04:29:15 +0000 Cc: Florian Schmaus Message-Id: <44DF820D-602C-4DE6-8BE7-B9E3A858B53D@gentoo.org> References: <20230106172051.274199-1-flow@gentoo.org> <20230106172051.274199-2-flow@gentoo.org> To: gentoo-dev@lists.gentoo.org X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Archives-Salt: 63f9f511-5fc2-4c7d-9b92-2233a71834b8 X-Archives-Hash: d9ba748ea6224f3deca4a944ff60387c --Apple-Mail=_E3BBCF7F-1E36-4F26-9598-498A59879606 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On 6 Jan 2023, at 17:20, Florian Schmaus wrote: > > Signed-off-by: Florian Schmaus > --- > eclass/gradle.eclass | 149 +++++++++++++++++++++++++++++++++++++++++ > eclass/tests/gradle.sh | 62 +++++++++++++++++ > 2 files changed, 211 insertions(+) > create mode 100644 eclass/gradle.eclass > create mode 100755 eclass/tests/gradle.sh > > diff --git a/eclass/gradle.eclass b/eclass/gradle.eclass > [...] > + > +# @ECLASS_VARIABLE: EGRADLE_MIN > +# @DEFAULT_UNSET > +# @DESCRIPTION: > +# Minimum required gradle version. > + > +# @ECLASS_VARIABLE: EGRADLE_MAX_EXCLUSIVE > +# @DEFAULT_UNSET > +# @DESCRIPTION: > +# First gradle version that is not supported. > + > +# @ECLASS_VARIABLE: EGRADLE_EXACT_VER > +# @DEFAULT_UNSET > +# @DESCRIPTION: > +# The exact required gradle version. > + It feels a pity to not use the now-somewhat standard PYTHON_COMPAT/LUA_COMPAT-style API. Is there a reason not to? If it doesn't fit how Gradle versioning works / the number of targets is likely to be far too high, It's fine as-is. --Apple-Mail=_E3BBCF7F-1E36-4F26-9598-498A59879606 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY7j1HV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kKpeAQCBH5smqDdTCY02jTfwoewf5um/Un4LHRiMeIerXuCmzwEAjHkDVgLj12Vu XtlA1yTKXGB/SwFdoaWVsWYfQ0FcKQ0= =W5ln -----END PGP SIGNATURE----- --Apple-Mail=_E3BBCF7F-1E36-4F26-9598-498A59879606--