[gentoo-dev] Setting USE_EXPAND defaults in profiles (in some cases)

[gentoo-dev] Setting USE_EXPAND defaults in profiles (in some cases)

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

For ebuilds that use USE_EXPAND to pull in other dependencies rather
than just internally building drivers (I suspect xorg is the only one),
I've been thinking of a way to make the whole setup cleaner.

agaffney suggested this in the first place, and every time I think about
it, it seems like a better idea. If we set VIDEO_CARDS and INPUT_DEVICES
in the arch profiles, we get the arch-specific defaults we need without
the really hugely ugly indecipherable mess in the ebuilds that nobody
can understand besides Josh_B and me. The very strange corner case this
doesn't work with is if people manually set VIDEO_CARDS="", then they
will no longer get the behavior of pulling in everything. But the
default case will still work great.

I'm going to go ahead with this in the next week or so unless I hear
massive objections.

Thanks,
Donnie


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [gentoo-dev] Setting USE_EXPAND defaults in profiles (in some cases)

[Harald van Dijk]

On Thu, Aug 03, 2006 at 08:27:37PM -0700, Donnie Berkholz wrote:
> The very strange corner case this
> doesn't work with is if people manually set VIDEO_CARDS="", then they
> will no longer get the behavior of pulling in everything. But the
> default case will still work great.

If people manually explicitly empty VIDEO_CARDS, not pulling in
anything is a good thing. The only problem for me is that it means
even more work getting USE_EXPAND support in ufed, but that
should only be a problem for me :)
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Setting USE_EXPAND defaults in profiles (in some cases)

[Zac Medico]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Donnie Berkholz wrote:
> agaffney suggested this in the first place, and every time I think about
> it, it seems like a better idea. If we set VIDEO_CARDS and INPUT_DEVICES
> in the arch profiles, we get the arch-specific defaults we need without
> the really hugely ugly indecipherable mess in the ebuilds that nobody
> can understand besides Josh_B and me. The very strange corner case this
> doesn't work with is if people manually set VIDEO_CARDS="", then they
> will no longer get the behavior of pulling in everything. But the
> default case will still work great.

As of portage-2.1.1_pre4-r4, VIDEO_CARDS="" should now continue to work like before no matter how you've enabled the flags in the profile.  As part of the fix for bug 142125, portage automatically regenerates all of the USE_EXPAND variables to be consistent with the corresponding USE flags.

Zac
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD4DBQFE1mGp/ejvha5XGaMRAnhWAJ9NeulfMvFrDdVShwY/WvF5LjyDvgCXf8wp
fhFLQyRy2Cpdq/H81QMyPg==
=/UiE
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Setting USE_EXPAND defaults in profiles (in some cases)

[Jakub Moc]

[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]

Zac Medico wrote:
> Donnie Berkholz wrote:
>>> agaffney suggested this in the first place, and every time I think about
>>> it, it seems like a better idea. If we set VIDEO_CARDS and INPUT_DEVICES
>>> in the arch profiles, we get the arch-specific defaults we need without
>>> the really hugely ugly indecipherable mess in the ebuilds that nobody
>>> can understand besides Josh_B and me. The very strange corner case this
>>> doesn't work with is if people manually set VIDEO_CARDS="", then they
>>> will no longer get the behavior of pulling in everything. But the
>>> default case will still work great.
> 
> As of portage-2.1.1_pre4-r4, VIDEO_CARDS="" should now continue to work like 
> before no matter how you've enabled the flags in the profile.

> As part of the fix for bug 142125, portage automatically regenerates all of 
> the USE_EXPAND variables to be consistent with the corresponding USE
flags.
> 
> Zac

Well, please don't change the behaviour in every other release, it's
very confusing and people file bugs about it. And -r4 behaviour is
incorrect, as it ignores defaults in profiles when you set anything in
make.conf. -r3 got it correctly so that foo in profiles could be
overriden with -foo in make.conf, this doesn't work any more in -r4.


-- 
Best regards,

 Jakub Moc
 mailto:jakub@gentoo.org
 GPG signature:
 http://subkeys.pgp.net:11371/pks/lookup?op=get&search=0xCEBA3D9E
 Primary key fingerprint: D2D7 933C 9BA1 C95B 2C95  B30F 8717 D5FD CEBA 3D9E

 ... still no signature   ;)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Setting USE_EXPAND defaults in profiles (in some cases)

[Harald van Dijk]

On Mon, Aug 07, 2006 at 10:01:12AM +0200, Jakub Moc wrote:
> Zac Medico wrote:
> > Donnie Berkholz wrote:
> >>> agaffney suggested this in the first place, and every time I think about
> >>> it, it seems like a better idea. If we set VIDEO_CARDS and INPUT_DEVICES
> >>> in the arch profiles, we get the arch-specific defaults we need without
> >>> the really hugely ugly indecipherable mess in the ebuilds that nobody
> >>> can understand besides Josh_B and me. The very strange corner case this
> >>> doesn't work with is if people manually set VIDEO_CARDS="", then they
> >>> will no longer get the behavior of pulling in everything. But the
> >>> default case will still work great.
> > 
> > As of portage-2.1.1_pre4-r4, VIDEO_CARDS="" should now continue to work like 
> > before no matter how you've enabled the flags in the profile.
> 
> > As part of the fix for bug 142125, portage automatically regenerates all of 
> > the USE_EXPAND variables to be consistent with the corresponding USE
> flags.
> > 
> > Zac
> 
> Well, please don't change the behaviour in every other release, it's
> very confusing and people file bugs about it. And -r4 behaviour is
> incorrect, as it ignores defaults in profiles when you set anything in
> make.conf. -r3 got it correctly so that foo in profiles could be
> overriden with -foo in make.conf, this doesn't work any more in -r4.

That was a bug, not a feature. Older portage versions behave as -r4
does, and -r3's behaviour forces users to set invalid values in
certain cases.
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Setting USE_EXPAND defaults in profiles (in some cases)

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

Donnie Berkholz wrote:
> For ebuilds that use USE_EXPAND to pull in other dependencies rather
> than just internally building drivers (I suspect xorg is the only one),
> I've been thinking of a way to make the whole setup cleaner.
> 
> agaffney suggested this in the first place, and every time I think about
> it, it seems like a better idea. If we set VIDEO_CARDS and INPUT_DEVICES
> in the arch profiles, we get the arch-specific defaults we need without
> the really hugely ugly indecipherable mess in the ebuilds that nobody
> can understand besides Josh_B and me. The very strange corner case this
> doesn't work with is if people manually set VIDEO_CARDS="", then they
> will no longer get the behavior of pulling in everything. But the
> default case will still work great.
> 
> I'm going to go ahead with this in the next week or so unless I hear
> massive objections.

It's done. Let me know if anything breaks, although repoman OK'd the
changes to the ebuilds and I've tested or had test results reported from
3 architectures.

Thanks,
Donnie


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]