From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
	by nuthatch.gentoo.org with esmtp (Exim 4.54)
	id 1FUSsJ-0005We-6A
	for garchives@archives.gentoo.org; Fri, 14 Apr 2006 18:18:31 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
	by robin.gentoo.org (8.13.6/8.13.5) with SMTP id k3EIIBjA023246;
	Fri, 14 Apr 2006 18:18:11 GMT
Received: from cs.ubishops.ca (inglit.ubishops.ca [206.167.194.132])
	by robin.gentoo.org (8.13.6/8.13.5) with ESMTP id k3EIGESF002542
	for <gentoo-dev@lists.gentoo.org>; Fri, 14 Apr 2006 18:16:14 GMT
Received: from [192.168.0.5] (toronto-HSE-ppp4050394.sympatico.ca [70.48.221.50])
	by cs.ubishops.ca (Postfix) with ESMTP id A123B3A7E3
	for <gentoo-dev@lists.gentoo.org>; Fri, 14 Apr 2006 14:16:13 -0400 (EDT)
Message-ID: <443FE709.5040407@gentoo.org>
Date: Fri, 14 Apr 2006 14:16:41 -0400
From: Patrick McLean <chutzpah@gentoo.org>
User-Agent: Mail/News 1.5 (X11/20060331)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about
 bad CFLAGS
References: <443EAB73.6030804@gentoo.org> <443F076C.8030005@gentoo.org> <443F0DB4.2070203@gentoo.org> <20060414062703.GA1111@gentoo.org> <443FE03D.1050907@gentoo.org> <443FE419.7000201@gentoo.org>
In-Reply-To: <443FE419.7000201@gentoo.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Archives-Salt: a0395031-b096-4e05-a139-4873ad61443d
X-Archives-Hash: 558f6b144b30b4411da4792239badb85

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Joshua Nichols wrote:
> Patrick McLean wrote:
>> There is a new version at
>> http://dev.gentoo.org/~chutzpah/profile.bashrc that
>> should fix all these possible problems. Thanks for pointing them out,
> Around line 77, you have:
>         hasme ${flag} ${CFLAGS} ${CXXFLAGS} && trigger=1 && \
>         ewarn "Your C(XX)FLAGS contain(s) \"${flag}\" which can break
> packages."
> 
> Might I suggest you change it to something like:
> 
>     if hasme ${flag} ${CFLAGS} ${CXXFLAGS}; then
>        trigger=1
>        ewarn "Your C(XX)FLAGS contain(s) \"${flag}\" which can break
> packages."
>     fi
> 
Done.

> While there's nothing wrong with the original way, my suggestion would
> make it a bit more obvious that you're setting the 'trigger' flag.
> 
Readability is always a good thing :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEP+cJWt/XSf2CZdkRAoGtAJ9e8CViKyluILpEH07J3i50ciuNnwCZAVu/
M94FKLlae7tyTRZ8TsE40zA=
=XkHW
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list