From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1C14A138334 for ; Sat, 7 Dec 2019 00:16:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 495A1E08A6; Sat, 7 Dec 2019 00:16:36 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 01809E0864 for ; Sat, 7 Dec 2019 00:16:35 +0000 (UTC) Received: from ws.localnet (unknown [100.42.98.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gyakovlev) by smtp.gentoo.org (Postfix) with ESMTPSA id E2C6B34D85B for ; Sat, 7 Dec 2019 00:16:34 +0000 (UTC) From: Georgy Yakovlev To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations Date: Fri, 06 Dec 2019 16:16:32 -0800 Message-ID: <4427138.OatnvYpNUp@ws> In-Reply-To: <20191206234438.63218eb2@sf> References: <20191206200931.22347-1-gyakovlev@gentoo.org> <20191206234438.63218eb2@sf> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6015114.gi5ti23HVM"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Archives-Salt: a04e5bca-e992-4f0e-8904-65dc2cd7f5b7 X-Archives-Hash: 8571a638e11ee1531105ef4233917385 --nextPart6015114.gi5ti23HVM Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, December 6, 2019 3:44:38 PM PST Sergei Trofimovich wrote: > On Fri, 6 Dec 2019 12:09:31 -0800 > > Georgy Yakovlev wrote: > > Default output just prints crate name. > > With -vv we can see all cargo options and rustc args. > > > > Signed-off-by: Georgy Yakovlev > > --- > > Looks good! > > I had to do an equivalent locally at least a few times. Pushed! > > While at it I also suggest adding equivalent of > econf's/emake's ${EXTRA_ECONF} and ${EXTRA_EMAKE} > to allow users to inject arbitrary stuff. For example > to sneak in '-Z' options globally. > > Say, ${CARGO_BUILD_EXTRA}, ${CARGO_INSTALL_EXTRA}, > ${CARGO_TEST_EXTRA}. > Yeah, it's on my to-do list for this eclass. 1 question tho, should it come after "$@" or before? Do you use it? I know cargo can be picky about order and some ebuilds rely on passing params in phase funcs. --nextPart6015114.gi5ti23HVM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE3NQc5d2Nq7vhc9JNonLI8BUSnVIFAl3q72AACgkQonLI8BUS nVICNRAAtybUAka4enuyL+LyXwHXFpy1pDlXsIBRk6D+SHS2+6KRMIcMJspffXlh BkO52yaENOUl23fYetplrNklYQw+lJfiNUmPnMyFofTVioU7WwUG2lM4xa5W6Lit g1ROyG4C8MBZQRgMuFX1NURXxJaB65n5btE0DZaNaaoyAWR0NaMPJ/oPt42V+TPA Xzfy0SbDhoEvtO3YAwMqsUx2jXpItWRdDxQWseETZVkWQ8kNSoVDiOyGnTuefgpm E4Rkc17bb7bBao8u1/FelmZuSCplBA0i5T5yGbd25sno+FrRZ9o7u9oK+8l8FoqH tAhy+DGQ2Els6LqOjTcV7tjbalF8hyLoDCo9zEScDEZ2zRPvK+N4h4UiC1LDVn0c uE9m1N6nTrJuC0LQ6kW3iWhU015wIIHKPhkHHa+Xpu47ak54uWIwmbYD0pXeqWlM elL8fYrFBqc4wRGIc/t1xmVbAuIyBluqU3kWmoEoQoM8G5JgsxUHJBmVXPEh65sG OfG0QLa6wDs2Ic55/W5VFG9cefeapqBLJgmmHo//hhRB+NYJZ3eMFX0LUyHzGATG SLsj8A2GXkQTcYT5WGqt4iL2kEha6yEXhpZzKWM2VeFh2/eXTGojD91ieUYICjrh 38g/OebWvZGLxI27R+LVD41I8BOkC3YMLBXALAdTLlTVvKKJjHw= =taGb -----END PGP SIGNATURE----- --nextPart6015114.gi5ti23HVM--