* [gentoo-dev] mozextension.eclass last call!
@ 2005-12-30 4:21 Jory A. Pratt
2005-12-30 4:44 ` Dan Meltzer
2005-12-30 11:15 ` Petteri Räty
0 siblings, 2 replies; 7+ messages in thread
From: Jory A. Pratt @ 2005-12-30 4:21 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Unless there are any major objections tomorrow night I will commit
mozextension.eclass to the tree. You can find mozextension.eclass at
http://dev.gentoo.org/~anarchy/eclass . You can also find the firefox
and firefox-bin ebuilds at http://dev.gentoo.org/~anarchy/ebuilds that
are waiting to go to be added to the tree which inherit mozextension.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFDtLXYGDfjNg8unQIRAlIUAJ9zqAw9woC2vyIOwv8LX4dR3GZ1AQCeJwPY
Mmu6Xk5Qt8rJxh5n1k770oc=
=RH5S
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] mozextension.eclass last call!
2005-12-30 4:21 [gentoo-dev] mozextension.eclass last call! Jory A. Pratt
@ 2005-12-30 4:44 ` Dan Meltzer
2005-12-30 10:42 ` Stefan Schweizer
2005-12-30 11:15 ` Petteri Räty
1 sibling, 1 reply; 7+ messages in thread
From: Dan Meltzer @ 2005-12-30 4:44 UTC (permalink / raw
To: gentoo-dev
On 12/29/05, Jory A. Pratt <anarchy@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Unless there are any major objections tomorrow night I will commit
> mozextension.eclass to the tree. You can find mozextension.eclass at
> http://dev.gentoo.org/~anarchy/eclass . You can also find the firefox
> and firefox-bin ebuilds at http://dev.gentoo.org/~anarchy/ebuilds that
> are waiting to go to be added to the tree which inherit mozextension.
>
Do you mind addressing http://article.gmane.org/gmane.linux.gentoo.devel/34397
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFDtLXYGDfjNg8unQIRAlIUAJ9zqAw9woC2vyIOwv8LX4dR3GZ1AQCeJwPY
> Mmu6Xk5Qt8rJxh5n1k770oc=
> =RH5S
> -----END PGP SIGNATURE-----
> --
> gentoo-dev@gentoo.org mailing list
>
>
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] mozextension.eclass last call!
2005-12-30 4:44 ` Dan Meltzer
@ 2005-12-30 10:42 ` Stefan Schweizer
2005-12-30 14:48 ` Dan Meltzer
2005-12-30 19:50 ` Lance Albertson
0 siblings, 2 replies; 7+ messages in thread
From: Stefan Schweizer @ 2005-12-30 10:42 UTC (permalink / raw
To: gentoo-dev
On 12/30/05, Dan Meltzer <parallelgrapefruit@gmail.com> wrote:
> On 12/29/05, Jory A. Pratt <anarchy@gentoo.org> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Unless there are any major objections tomorrow night I will commit
> > mozextension.eclass to the tree. You can find mozextension.eclass at
> > http://dev.gentoo.org/~anarchy/eclass . You can also find the firefox
> > and firefox-bin ebuilds at http://dev.gentoo.org/~anarchy/ebuilds that
> > are waiting to go to be added to the tree which inherit mozextension.
> >
> Do you mind addressing http://article.gmane.org/gmane.linux.gentoo.devel/34397
You are kidding?
It had enough time now.
And it was already addressed as the eclass was not added on monday.
- Stefan
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] mozextension.eclass last call!
2005-12-30 4:21 [gentoo-dev] mozextension.eclass last call! Jory A. Pratt
2005-12-30 4:44 ` Dan Meltzer
@ 2005-12-30 11:15 ` Petteri Räty
1 sibling, 0 replies; 7+ messages in thread
From: Petteri Räty @ 2005-12-30 11:15 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 2676 bytes --]
Jory A. Pratt wrote:
> Unless there are any major objections tomorrow night I will commit
> mozextension.eclass to the tree. You can find mozextension.eclass at
> http://dev.gentoo.org/~anarchy/eclass . You can also find the firefox
> and firefox-bin ebuilds at http://dev.gentoo.org/~anarchy/ebuilds that
> are waiting to go to be added to the tree which inherit mozextension.
>
http://dev.gentoo.org/~anarchy/eclass/mozconfig-2.eclass
if use debug; then
mozconfig_annotate +debug \
--enable-debug \
--enable-tests \
--disable-reorder \
--disable-strip \
--disable-strip-libs \
--enable-debugger-info-modules=ALL_MODULES
else
mozconfig_annotate -debug \
--disable-debug \
--disable-tests \
--enable-reorder \
--enable-strip \
--enable-strip-libs
I would use a local variable for the common options to avoid code
duplication.
http://dev.gentoo.org/~anarchy/eclass/mozcoreconf.eclass
declare MOZ=$([[ ${PN} == mozilla || ${PN} == gecko-sdk ]] && echo true
|| echo false)
declare FF=$([[ ${PN} == *firefox ]] && echo true || echo false)
declare TB=$([[ ${PN} == *thunderbird ]] && echo true || echo false)
declare SB=$([[ ${PN} == *sunbird ]] && echo true || echo false)
declare EM=$([[${PN} == *enig]] && echo true || echo false)
[[${PN} == *enig]] && echo true || echo false
This seems to be duplicated here many times. Consider making this a
helper function.
mozconfig_final() {
declare ac opt hash reason
You seem to be using declare to keep variables local. I think it is more
common to use the local keyword for this:
betelgeuse@pena /usr/portage/eclass $ grep local * | wc -l
810
betelgeuse@pena /usr/portage/eclass $ grep declare * | wc -l
41
Why is mozconfig_final here three times?
http://dev.gentoo.org/~anarchy/eclass/mozextension.eclass
Consider adding debug-print calls to your functions.
if [ "${x:0:2}" = "./" ] ; then
srcdir=""
else
srcdir="${DISTDIR}/"
fi
srcdir is not declared local in the beginning of the function
Check this for other variables too.
cd "${WORKDIR}" || die "$myfail"
for consistency you should probably use ${myfail}
[ ${#} -ne 1 ] && die "'xpi_install' takes exactly one argument"
you can use FUNCNAME variable to get the name of the function
cd ${x}
Don't know if this can contain spaces but best to be sure and add
quotes. I also noticed a couple of other places where pathnames are not
quoted.
emid=$(sed -n '/<\?em:id>\?/!d; s/.*\([\"{].*[}\"]\).*/\1/; s/\"//g; p;
q' ${x}/install.rdf)
Consider adding some comments about what this is supposed to do so that
people who are looking at the code the first time get some kind of an idea.
Regards,
Petteri
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] mozextension.eclass last call!
2005-12-30 10:42 ` Stefan Schweizer
@ 2005-12-30 14:48 ` Dan Meltzer
2005-12-30 14:59 ` Stefan Schweizer
2005-12-30 19:50 ` Lance Albertson
1 sibling, 1 reply; 7+ messages in thread
From: Dan Meltzer @ 2005-12-30 14:48 UTC (permalink / raw
To: gentoo-dev
On 12/30/05, Stefan Schweizer <genstef@gentoo.org> wrote:
> On 12/30/05, Dan Meltzer <parallelgrapefruit@gmail.com> wrote:
> > On 12/29/05, Jory A. Pratt <anarchy@gentoo.org> wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Unless there are any major objections tomorrow night I will commit
> > > mozextension.eclass to the tree. You can find mozextension.eclass at
> > > http://dev.gentoo.org/~anarchy/eclass . You can also find the firefox
> > > and firefox-bin ebuilds at http://dev.gentoo.org/~anarchy/ebuilds that
> > > are waiting to go to be added to the tree which inherit mozextension.
> > >
> > Do you mind addressing http://article.gmane.org/gmane.linux.gentoo.devel/34397
>
>
> You are kidding?
> It had enough time now.
>
> And it was already addressed as the eclass was not added on monday.
My appologies, time off has been messing with my sense of what day it is :)
Carry on!
>
> - Stefan
>
> --
> gentoo-dev@gentoo.org mailing list
>
>
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] mozextension.eclass last call!
2005-12-30 14:48 ` Dan Meltzer
@ 2005-12-30 14:59 ` Stefan Schweizer
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Schweizer @ 2005-12-30 14:59 UTC (permalink / raw
To: gentoo-dev
On 12/30/05, Dan Meltzer <parallelgrapefruit@gmail.com> wrote:
> > > Do you mind addressing http://article.gmane.org/gmane.linux.gentoo.devel/34397
> >
> >
> > You are kidding?
> > It had enough time now.
> >
> > And it was already addressed as the eclass was not added on monday.
>
> My appologies, time off has been messing with my sense of what day it is :)
>
> Carry on!
But you have a point anyway .. I think we should wait till after the
holidays because some people only scan their mail at work.
S my proposed merge date is 6th of january provided all comments are
addressed till then.
Thank you,
- Stefan
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] mozextension.eclass last call!
2005-12-30 10:42 ` Stefan Schweizer
2005-12-30 14:48 ` Dan Meltzer
@ 2005-12-30 19:50 ` Lance Albertson
1 sibling, 0 replies; 7+ messages in thread
From: Lance Albertson @ 2005-12-30 19:50 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]
Stefan Schweizer wrote:
> On 12/30/05, Dan Meltzer <parallelgrapefruit@gmail.com> wrote:
>
>>On 12/29/05, Jory A. Pratt <anarchy@gentoo.org> wrote:
>>> Unless there are any major objections tomorrow night I will commit
>>>mozextension.eclass to the tree. You can find mozextension.eclass at
>>>http://dev.gentoo.org/~anarchy/eclass . You can also find the firefox
>>>and firefox-bin ebuilds at http://dev.gentoo.org/~anarchy/ebuilds that
>>>are waiting to go to be added to the tree which inherit mozextension.
>>>
>>
>>Do you mind addressing http://article.gmane.org/gmane.linux.gentoo.devel/34397
> You are kidding?
> It had enough time now.
A lot of people take this whole week off or on vacation away from email.
Plus, I have yet to see a reason why it has to be pushed over the
holidays and not waited until after it.
--
Lance Albertson <ramereth@gentoo.org>
Gentoo Infrastructure | Operations Manager
---
GPG Public Key: <http://www.ramereth.net/lance.asc>
Key fingerprint: 0423 92F3 544A 1282 5AB1 4D07 416F A15D 27F4 B742
ramereth/irc.freenode.net
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-12-30 19:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-30 4:21 [gentoo-dev] mozextension.eclass last call! Jory A. Pratt
2005-12-30 4:44 ` Dan Meltzer
2005-12-30 10:42 ` Stefan Schweizer
2005-12-30 14:48 ` Dan Meltzer
2005-12-30 14:59 ` Stefan Schweizer
2005-12-30 19:50 ` Lance Albertson
2005-12-30 11:15 ` Petteri Räty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox