From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.54) id 1EqrvH-00076f-CP for garchives@archives.gentoo.org; Mon, 26 Dec 2005 12:57:55 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.5/8.13.5) with SMTP id jBQCv4QZ029676; Mon, 26 Dec 2005 12:57:04 GMT Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi [195.197.172.116]) by robin.gentoo.org (8.13.5/8.13.5) with ESMTP id jBQCrAUx032066 for ; Mon, 26 Dec 2005 12:53:10 GMT Received: from [192.168.150.87] (YYYMMMCCII.dsl.saunalahti.fi [85.76.10.103]) by gw02.mail.saunalahti.fi (Postfix) with ESMTP id 98301E27F1 for ; Mon, 26 Dec 2005 14:53:09 +0200 (EET) Message-ID: <43AFE7B3.8010602@gentoo.org> Date: Mon, 26 Dec 2005 14:53:07 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051206) X-Accept-Language: en-us, en Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] making dodoc and dohtml die when they fail and stricter is on References: <43AF2BF5.4060905@gentoo.org> <200512260913.39975.jstubbs@gentoo.org> <1566320872.20051226120137@gentoo.org> In-Reply-To: <1566320872.20051226120137@gentoo.org> X-Enigmail-Version: 0.92.0.0 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF98EE81C01EDF9B6F76696F7" X-Archives-Salt: cd39e4e4-7b98-412c-b55d-7d10238ee533 X-Archives-Hash: 0bd60dcc8a91fbb2c00e1499cc1c9307 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF98EE81C01EDF9B6F76696F7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Jakub Moc wrote: > >>>Currently there are quite a few ebuilds in the tree that execute dodoc or >>>dohtml for files that do not exist. I think it would be nice to have >>>ebuilds die if this is the case. To not break current ebuilds this would >>>only happen with FEATURES="stricter". > > > Sigh... There are already bugs flowing in for TEXTRELs/executable stacks > checks implemented in recent portage versions. Some of these bugs are > completely INVALID or CANTFIX - emulation stuff, binary-only ebuilds, etc. > etc. What's the point of this breakage? Why are these QA checks fatal, > causing ebuilds to bail out? How can you disable such checks per-ebuild > (AFAIK - you can't) to not annoy users with QA notices and breakage one can > do nothing about anyway? > > As Flameeyes pointed out, dodoc/dohtml is also used in eclasses. This can > break many ebuilds. Users will report duplicate bugs because they will not > realize that it's the eclass causing the failure, not the ebuild. Again, > what's the point? How will it work with FEATURES="nodoc"? Why should an > ebuild ever fail just because some doc file is missing or got renamed or > whatever? > > echo "dodoc: ${x} does not exist" 1>&2 This should not be showed to users then because we know this to happen and do not want to do anything about it. Also try to remember that not every package is done following the GNU conventions (Java). It can happen that the doc files are for example renamed and dieing will help catch this. dodoc/dohtml dieing will not have any affect on FEATURES="nodoc". How about making it possible to tell dodoc/dohtml not to die as an argument/variable/whatever? We could also have new diedodoc functions, but it would be nice to keep this as simple as possible. Regards, Petteri --------------enigF98EE81C01EDF9B6F76696F7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDr+e1cxLzpIGCsLQRAqF6AKCa/MC1auDKNFVmw79bn119oTuTBACfSJWp uPX4aLlLXY+1SI6kqOo313g= =2Zwa -----END PGP SIGNATURE----- --------------enigF98EE81C01EDF9B6F76696F7-- -- gentoo-dev@gentoo.org mailing list