[gentoo-dev] [PATCH] profiles/default/linux: set gl_cv_type_time_t_bits_macro=no

[gentoo-dev] [PATCH] profiles/default/linux: set gl_cv_type_time_t_bits_macro=no

[Mike Gilbert]

This is intended to prevent packages from automatically switching to
64-bit time_t on 32-bit ABIs. Making this switch in an uncontrolled
manner will lead to inconsistent library ABIs that fail at runtime.

At a later time, we will introduce new profiles to enable 64-bit time_t
distro-wide.

https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration

Bug: https://bugs.gentoo.org/828001
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
---
 profiles/default/linux/make.defaults | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults
index 6ae7cf297cf..53ace7e229c 100644
--- a/profiles/default/linux/make.defaults
+++ b/profiles/default/linux/make.defaults
@@ -53,3 +53,7 @@ VIDEO_CARDS="dummy fbdev v4l"
 # Note that adding LDFLAGS="-Wl,-O1 ${LDFLAGS}" breaks dev-util/boost-build
 # because of whitespace.
 LDFLAGS="-Wl,-O1 -Wl,--as-needed"
+
+# Mike Gilbert <floppym@gentoo.org> (2021-12-17)
+# Prevent automagic use of 64-bit time_t.
+gl_cv_type_time_t_bits_macro="no"
-- 
2.34.1

Re: [gentoo-dev] [PATCH] profiles/default/linux: set gl_cv_type_time_t_bits_macro=no

[Alec Warner]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

Can you put the bug # in the comment in the file?

On Fri, Dec 17, 2021, 09:42 Mike Gilbert <floppym@gentoo.org> wrote:

> This is intended to prevent packages from automatically switching to
> 64-bit time_t on 32-bit ABIs. Making this switch in an uncontrolled
> manner will lead to inconsistent library ABIs that fail at runtime.
>
> At a later time, we will introduce new profiles to enable 64-bit time_t
> distro-wide.
>
> https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration
>
> Bug: https://bugs.gentoo.org/828001
> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> ---
>  profiles/default/linux/make.defaults | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/profiles/default/linux/make.defaults
> b/profiles/default/linux/make.defaults
> index 6ae7cf297cf..53ace7e229c 100644
> --- a/profiles/default/linux/make.defaults
> +++ b/profiles/default/linux/make.defaults
> @@ -53,3 +53,7 @@ VIDEO_CARDS="dummy fbdev v4l"
>  # Note that adding LDFLAGS="-Wl,-O1 ${LDFLAGS}" breaks
> dev-util/boost-build
>  # because of whitespace.
>  LDFLAGS="-Wl,-O1 -Wl,--as-needed"
> +
> +# Mike Gilbert <floppym@gentoo.org> (2021-12-17)
> +# Prevent automagic use of 64-bit time_t.
> +gl_cv_type_time_t_bits_macro="no"
> --
> 2.34.1
>
>
>

[-- Attachment #2: Type: text/html, Size: 2034 bytes --]

Re: [gentoo-dev] [PATCH] profiles/default/linux: set gl_cv_type_time_t_bits_macro=no

[James Le Cuirot]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Fri, 2021-12-17 at 09:41 -0500, Mike Gilbert wrote:
> This is intended to prevent packages from automatically switching to
> 64-bit time_t on 32-bit ABIs. Making this switch in an uncontrolled
> manner will lead to inconsistent library ABIs that fail at runtime.
> 
> At a later time, we will introduce new profiles to enable 64-bit time_t
> distro-wide.
> 
> https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration
> 
> Bug: https://bugs.gentoo.org/828001
> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> ---
>  profiles/default/linux/make.defaults | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults
> index 6ae7cf297cf..53ace7e229c 100644
> --- a/profiles/default/linux/make.defaults
> +++ b/profiles/default/linux/make.defaults
> @@ -53,3 +53,7 @@ VIDEO_CARDS="dummy fbdev v4l"
>  # Note that adding LDFLAGS="-Wl,-O1 ${LDFLAGS}" breaks dev-util/boost-build
>  # because of whitespace.
>  LDFLAGS="-Wl,-O1 -Wl,--as-needed"
> +
> +# Mike Gilbert <floppym@gentoo.org> (2021-12-17)
> +# Prevent automagic use of 64-bit time_t.
> +gl_cv_type_time_t_bits_macro="no"

What will we do about other build systems? I worry they won't have a
consistent approach for all projects.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

Re: [gentoo-dev] [PATCH] profiles/default/linux: set gl_cv_type_time_t_bits_macro=no

[Mike Gilbert]

On Sat, Dec 18, 2021 at 10:35 AM James Le Cuirot <chewi@gentoo.org> wrote:
> What will we do about other build systems? I worry they won't have a
> consistent approach for all projects.

We will have to deal with them as we discover them. I don't see a
magic solution for everything.

I suppose we could add a new profile var (eg. TIME_BITS) that ebuild
maintainers could reference to control this for non-autoconf/gnulib
build systems.

Also, if some common build system like meson adds automagic support,
we could override that in meson.eclass.